Closed
Bug 708231
Opened 13 years ago
Closed 13 years ago
Fix set-but-unused warnings reported by GCC 4.6 in jsexn.cpp
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: igor, Assigned: igor)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.68 KB,
patch
|
evilpie
:
review+
|
Details | Diff | Splinter Review |
The attached patch removes unused CallArgs args = CallArgsFromVp(argc, vp) from exn_toSource that was added in the bug 700169.
Attachment #579672 -
Flags: review?(evilpies)
|
||
Updated•13 years ago
|
Attachment #579672 -
Attachment is patch: true
Attachment #579672 -
Attachment mime type: text/x-c++src → text/plain
|
|
||
Comment 1•13 years ago
|
||
Comment on attachment 579672 [details] [diff] [review]
remove uned args
Review of attachment 579672 [details] [diff] [review]:
-----------------------------------------------------------------
No idea how I missed that, would you mind rewriting the function so it uses |args| ?
Attachment #579672 -
Flags: review?(evilpies)
|
Assignee | |
Comment 2•13 years ago
|
||
The new patch replaces explicit vp[-1] and vp[-2] in exn_toSource with CallArgs calls.
Attachment #579672 -
Attachment is obsolete: true
Attachment #579679 -
Flags: review?(evilpies)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 579679 [details] [diff] [review]
do use CallArgs
Review of attachment 579679 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks
Attachment #579679 -
Flags: review?(evilpies) → review+
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•