Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 708231 - Fix set-but-unused warnings reported by GCC 4.6 in jsexn.cpp
: Fix set-but-unused warnings reported by GCC 4.6 in jsexn.cpp
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla11
Assigned To: Igor Bukanov
: Jason Orendorff [:jorendorff]
Depends on: 700169
  Show dependency treegraph
Reported: 2011-12-07 05:55 PST by Igor Bukanov
Modified: 2011-12-07 12:27 PST (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

remove uned args (695 bytes, patch)
2011-12-07 05:55 PST, Igor Bukanov
no flags Details | Diff | Splinter Review
do use CallArgs (1.68 KB, patch)
2011-12-07 06:56 PST, Igor Bukanov
evilpies: review+
Details | Diff | Splinter Review

Description Igor Bukanov 2011-12-07 05:55:35 PST
Created attachment 579672 [details] [diff] [review]
remove uned args

The attached patch removes unused  CallArgs args = CallArgsFromVp(argc, vp) from exn_toSource that was added in the bug 700169.
Comment 1 Tom Schuster [:evilpie] 2011-12-07 05:59:27 PST
Comment on attachment 579672 [details] [diff] [review]
remove uned args

Review of attachment 579672 [details] [diff] [review]:

No idea how I missed that, would you mind rewriting the function so it uses |args| ?
Comment 2 Igor Bukanov 2011-12-07 06:56:04 PST
Created attachment 579679 [details] [diff] [review]
do use CallArgs

The new patch replaces explicit vp[-1] and vp[-2] in exn_toSource with CallArgs calls.
Comment 3 Tom Schuster [:evilpie] 2011-12-07 06:59:35 PST
Comment on attachment 579679 [details] [diff] [review]
do use CallArgs

Review of attachment 579679 [details] [diff] [review]:

Comment 4 Matt Brubeck (:mbrubeck) 2011-12-07 12:27:06 PST

Note You need to log in before you can comment on or make changes to this bug.