Closed Bug 708231 Opened 8 years ago Closed 8 years ago

Fix set-but-unused warnings reported by GCC 4.6 in jsexn.cpp

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: igor, Assigned: igor)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch remove uned args (obsolete) — Splinter Review
The attached patch removes unused  CallArgs args = CallArgsFromVp(argc, vp) from exn_toSource that was added in the bug 700169.
Attachment #579672 - Flags: review?(evilpies)
Attachment #579672 - Attachment is patch: true
Attachment #579672 - Attachment mime type: text/x-c++src → text/plain
Comment on attachment 579672 [details] [diff] [review]
remove uned args

Review of attachment 579672 [details] [diff] [review]:
-----------------------------------------------------------------

No idea how I missed that, would you mind rewriting the function so it uses |args| ?
Attachment #579672 - Flags: review?(evilpies)
Attached patch do use CallArgsSplinter Review
The new patch replaces explicit vp[-1] and vp[-2] in exn_toSource with CallArgs calls.
Attachment #579672 - Attachment is obsolete: true
Attachment #579679 - Flags: review?(evilpies)
Comment on attachment 579679 [details] [diff] [review]
do use CallArgs

Review of attachment 579679 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #579679 - Flags: review?(evilpies) → review+
https://hg.mozilla.org/mozilla-central/rev/70ca58127396
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.