708253 - Use IDL for Components.(utils.)reportError

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 579691 [details] [diff] [review]
Patch v1

>+    [deprecated,implicit_jscontext] void reportError(in jsval error);

I think we could use a space between the attributes (above as well).

>+nsXPCComponents_Utils::ReportError(const JS::Value& error, JSContext* cx)

The star and ampersand should be fixed (in a few other places as well).


>-    JSString* msgstr = JS_ValueToString(cx, argv[0]);

For a second there, I thought you were naming a variable after yourself. ;-)


>+    NS_ENSURE_SUCCESS(scripterr->InitWithWindowID(
>+            reinterpret_cast<const PRUnichar *>(msgchars),
>+            NS_ConvertUTF8toUTF16(fileName).get(),
>+            nsnull, lineNo, 0, 0, "XPConnect JavaScript", innerWindowID),
>+        NS_OK);

I'm not really a fan of this, because I find it jarring to see non-error-handing code wrapped up on an NS_ENSURE_* macro. I'd prefer to use an rv, and do NS_ENSURE_SUCCESS(rv, NS_OK).

r=bholley with that.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/b456317ba3e4