Created attachment 579691 [details] [diff] [review]
Comment on attachment 579691 [details] [diff] [review]
>+ [deprecated,implicit_jscontext] void reportError(in jsval error);
I think we could use a space between the attributes (above as well).
>+nsXPCComponents_Utils::ReportError(const JS::Value& error, JSContext* cx)
The star and ampersand should be fixed (in a few other places as well).
>- JSString* msgstr = JS_ValueToString(cx, argv);
For a second there, I thought you were naming a variable after yourself. ;-)
>+ reinterpret_cast<const PRUnichar *>(msgchars),
I'm not really a fan of this, because I find it jarring to see non-error-handing code wrapped up on an NS_ENSURE_* macro. I'd prefer to use an rv, and do NS_ENSURE_SUCCESS(rv, NS_OK).
r=bholley with that.