Spellchecker misspelling error ("non sequitur", not "non sequiter")

RESOLVED FIXED in mozilla22

Status

()

Core
Spelling checker
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: stacydan, Assigned: chandankumar)

Tracking

unspecified
mozilla22
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=ehsan])

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0.1) Gecko/20100101 Firefox/8.0.1
Build ID: 20111120135848

Steps to reproduce:

I occasionally encounter misspellings in the Thunderbird spellchecker


Actual results:

Non sequitur is returned as (non) requiter in hunderbird.  Curiously the spellchecker internal to this bug report recognizes  neither "sequiter" nor "sequitur" !  


Expected results:

(A non sequitur can denote an abrupt, illogical, unexpected or absurd turn of plot or dialogue not normally associated with or appropriate to that preceding it. A non sequitur joke has no explanation, but it reflects the idiosyncrasies, mental frames and alternative world of the particular comic persona.)  See most dictionaries. Also
http://en.wikipedia.org/wiki/Non_sequitur_(literary_device)

"I don't give a damn for a man that can only spell a word one way." -- Mark Twain 

I have a spelling checker 
It came with my PC 
It plainly marks for my revue 
Mistakes I cannot sea 
I've run this poem threw it 
I'm sure your please to no, 
It's letter perfect in it's weigh 
My checker tolled me sew 
-- anonymous

Comment 1

6 years ago
(In reply to stacydan from comment #0)
Maybe because this is considered by the spell checker as 2 words, not one. You probably (I'm not sure) will get the same in the spell checker of MS Office Word.
Component: General → Spelling checker
Product: Thunderbird → Core
QA Contact: general → spelling-checker
Version: 8 → unspecified
Whiteboard: [good first bug][mentor=ehsan]

Comment 2

5 years ago
It turns out that MS Word will indeed spell check correctly for non sequitur (my version anyway). . .
However, looking at the source and README in extensions/spellcheck/locales/en-US/hunspell/ leads me to believe that this is something to be dealt with upstream, and https://sourceforge.net/tracker/?atid=1014602&group_id=10079&func=browse
seemed like the place to do it.
Even if it doesn't get added, I think it would probably be a good idea to sync the file hunspell-en_US-20081205.dic with the more recent file in the README and remake the en-US.dic to reflect the numerous other additions to the file
(In reply to comment #2)
> It turns out that MS Word will indeed spell check correctly for non sequitur
> (my version anyway). . .
> However, looking at the source and README in
> extensions/spellcheck/locales/en-US/hunspell/ leads me to believe that this is
> something to be dealt with upstream, and
> https://sourceforge.net/tracker/?atid=1014602&group_id=10079&func=browse
> seemed like the place to do it.
> Even if it doesn't get added, I think it would probably be a good idea to sync
> the file hunspell-en_US-20081205.dic with the more recent file in the README
> and remake the en-US.dic to reflect the numerous other additions to the file

Could you create a patch for that, please?
(Assignee)

Comment 4

5 years ago
(in reply to comment #3)

Will i work on this.
i am a newbie. i know c language.
i found this bug interesting.
will i work on this?

Comment 5

5 years ago
Looks like someone was working on it and then disappeared? I'll take a look see at it too.
Please see <https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-US_dictionary> for instructions on how to add a word to the en-US dictionary.
Assignee: nobody → chandankumar.093047

Comment 7

5 years ago
(In reply to :Ehsan Akhgari from comment #6)
> Please see
> <https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-
> US_dictionary> for instructions on how to add a word to the en-US dictionary.

I followed the steps given in the above link and I basically added the words "sequitur" and "nonsequitur" in my dictionary files.But I am stuck up with the step 7.What should I do?
(In reply to comment #7)
> (In reply to :Ehsan Akhgari from comment #6)
> > Please see
> > <https://developer.mozilla.org/en-US/docs/Adding_a_new_word_to_the_en-
> > US_dictionary> for instructions on how to add a word to the en-US dictionary.
> 
> I followed the steps given in the above link and I basically added the words
> "sequitur" and "nonsequitur" in my dictionary files.But I am stuck up with the
> step 7.What should I do?

Pratik, chandankumar is also working on this.  Any chance you could pick up another mentored bug please?  Thanks!

Comment 9

4 years ago
Google translator lists the word as non sequiter. Is it really a bug?
(Assignee)

Comment 10

4 years ago
Created attachment 720265 [details]
It is a patch for the bug 708267.

I am attaching the patch for the bug 708267.
I have added two words "sequitur" and "non sequitur" in the dictionary.

Updated

4 years ago
Attachment #720265 - Flags: review?(ehsan)
(Reporter)

Comment 11

4 years ago
Thanks to all for thoughts and patches.  Ah!  The wonders of spell-checkers.  They do inject a bit of unintended humor in our lives. There's even a webpage on the logic of the non sequitur ("it does not follow" http://en.wikipedia.org/wiki/Non_sequitur_(logic)and of course the famous comic strip http://www.gocomics.com/nonsequitur and cast of characters http://en.wikipedia.org/wiki/Non_Sequitur_(comic_strip)
Comment on attachment 720265 [details]
It is a patch for the bug 708267.

Thanks for your patch.  But I think you only need to dd "sequitur" (lower case) to the dictionary.  "non" is already in there.
Attachment #720265 - Flags: review?(ehsan)
(Assignee)

Comment 13

4 years ago
Created attachment 721052 [details]
I have updated the patch for the bug 708267,

i have modified the word "sequitur" in small letter.
it is working.
Comment on attachment 721052 [details]
I have updated the patch for the bug 708267,

Review of attachment 721052 [details]:
-----------------------------------------------------------------

Looks like you have created this patch on top of your previous patch.  Can you please create a patch on top of a clean tree?  Thanks!
(Assignee)

Updated

4 years ago
Attachment #721052 - Attachment is obsolete: true
Attachment #721052 - Attachment is patch: false
(Assignee)

Updated

4 years ago
Attachment #720265 - Attachment is patch: false
(Assignee)

Updated

4 years ago
Attachment #720265 - Attachment is obsolete: true
(Assignee)

Comment 15

4 years ago
Created attachment 721065 [details]
It is a patch for the bug 708267.
(Assignee)

Comment 16

4 years ago
(In reply to :Ehsan Akhgari from comment #14)
>Can you please create a patch on top of a clean tree?  Thanks!
yes! I have created that one.
Please review it.
(Assignee)

Updated

4 years ago
Attachment #721065 - Flags: review?(ehsan)
Comment on attachment 721065 [details]
It is a patch for the bug 708267.

Hmm, this patch is empty...
Attachment #721065 - Flags: review?(ehsan)
(Assignee)

Updated

4 years ago
Attachment #721065 - Attachment is obsolete: true
Attachment #721065 - Attachment is patch: false
(Assignee)

Comment 18

4 years ago
Created attachment 721223 [details] [diff] [review]
It is a patch for the bug 708267.

i have fully checked the patch.
please merge it.
Attachment #721223 - Flags: review?(ehsan)
(Assignee)

Comment 19

4 years ago
(In reply to :Ehsan Akhgari from comment #17)
> Comment on attachment 721065 [details]
> It is a patch for the bug 708267.
> 
> Hmm, this patch is empty...
Sorry for that. i have cleaned the tree.
i have created the patch again.
Comment on attachment 721223 [details] [diff] [review]
It is a patch for the bug 708267.

Review of attachment 721223 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks!
Attachment #721223 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/68b019bea6d4
https://hg.mozilla.org/mozilla-central/rev/68b019bea6d4

Thanks for the patch!
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.