708330 - Use IDL for Components.utils.getWeakReference

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Yet another...

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 579758 [details] [diff] [review]
Patch v1

Looks good. r=bholley

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 579758 [details] [diff] [review]
Patch v1


>-nsXPCComponents_Utils::GetWeakReference(xpcIJSWeakReference **_retval)
>+nsXPCComponents_Utils::GetWeakReference(const JS::Value& object, JSContext* cx,
>+                                        xpcIJSWeakReference **_retval)

So, it looks like this should probably be const JS:Value &object, and JSContext *cx. XPConnect seems really inconsistent about this, but it seems like the dominant style is "Use JS star/ampersand placement for JSAPI types, and use gecko for gecko types". This is crappy, and I'm not sure whether we should change the latter part. But we might as well stick with the former.

So please change them in the patches where it's easy to do so, and for the rest of it don't sweat it too much.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/515da54158b2