708350 - aboutHom.dtd uses brand.dtd for some things but not others.

Status: RESOLVED DUPLICATE of bug 632264

(Firefox :: General, defect)

Description

[Mike Kaply [:mkaply]]

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/aboutHome.dtd

Has a couple references to Firefox and Mozilla that should use brandShortName and vendorShortName

Thanks for choosing Firefox!
It's easy to customize your Firefox
About Mozilla

Also, the link for about Mozilla (http://www.mozilla.com/about/) should be defined in a branding file somewhere, it should not be hardcoded in the file.

Comment 1

[Marco Bonardo [:mak]]

dupe of bug 632264?

Btw, third parties don't have to stick to about:home, they can provide their own start page.

Comment 2

[Mike Kaply [:mkaply]]

> Btw, third parties don't have to stick to about:home, they can provide their own start page.

I realize that, but considering the image comes out of branding, the favicon comes out of branding and the title of the page comes out of branding, it seems odd that other parts of the page don't come out of branding.

and yes, dupe.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Michael Kaply (mkaply) from comment #2)
> I realize that, but considering the image comes out of branding, the favicon
> comes out of branding and the title of the page comes out of branding, it
> seems odd that other parts of the page don't come out of branding.

Something could be improved, sure (The branding stuff there is mostly done for Aurora/Beta btw)
The patch in bug 632264 is a good start, but not enough to fix the issue (since also links need to be fixed)