708394 - Avoid LayoutInflater in constructors

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Sriram Ramasubramanian [:sriram]]

Using LayoutInflater will increase the time to load the UI. The same functionality can be used with <include/> and onFinishInflate(). It's better to remove the LayoutInflater used at various places.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This will help startup time

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patches uses <include/> and removes the LayoutInflation from most places.
While using profiler, I saw some performance win. Generally there is around 50-150ms faster UI on Nexus S and 5-20ms faster UI on Nexus.

The "onFinishInflate()" is called twice in pre-Honeycomb (or pre-ICS) phones -- reported here: http://www.androidadb.com/source/payforwarding-read-only/source/Android/GreenDroid/GreenDroid/src/greendroid/widget/ActionBar.java.html

I have a guard for the same.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38d339e5cf53

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/38d339e5cf53