Closed Bug 708405 Opened 12 years ago Closed 11 years ago

"Assertion failure: !cx->isExceptionPending()" with Proxy, old NodeList binding

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase (asserts fatally if pref is set)
262 bytes, text/html
Details
stack trace
10.48 KB, text/plain
Details
Make sure to propagate out failures from JS_HasPropertyById in the old nodelist resolve hook.
2.28 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review 
1. user_pref("dom.new_bindings", false);
2. Load the testcase

Result:

Assertion failure: !cx->isExceptionPending(), at /builds/slave/m-cen-osx64-dbg/build/js/src/jsinterp.cpp:4781
Attached file stack trace — 

    
    

    
  
This predates the new DOM binding work, for what it's worth.  It's a regression from bug 633133.  The return value of JS_HasPropertyById is being eaten.
Blocks: 633133

    
  
Assignee: nobody → bzbarsky
Priority: -- → P2
Whiteboard: [need review]

        Attachment #579970 -
        Flags: review?(mrbkap) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/403c7bcfb42a
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla11

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/403c7bcfb42a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.