Last Comment Bug 708405 - "Assertion failure: !cx->isExceptionPending()" with Proxy, old NodeList binding
: "Assertion failure: !cx->isExceptionPending()" with Proxy, old NodeList binding
Status: RESOLVED FIXED
: assertion, testcase
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Mac OS X
: P2 critical (vote)
: mozilla11
Assigned To: Boris Zbarsky [:bz] (Out June 25-July 6)
:
Mentors:
Depends on:
Blocks: 326633 633133
  Show dependency treegraph
 
Reported: 2011-12-07 13:47 PST by Jesse Ruderman
Modified: 2011-12-16 06:09 PST (History)
4 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (asserts fatally if pref is set) (262 bytes, text/html)
2011-12-07 13:47 PST, Jesse Ruderman
no flags Details
stack trace (10.48 KB, text/plain)
2011-12-07 13:47 PST, Jesse Ruderman
no flags Details
Make sure to propagate out failures from JS_HasPropertyById in the old nodelist resolve hook. (2.28 KB, patch)
2011-12-07 23:04 PST, Boris Zbarsky [:bz] (Out June 25-July 6)
mrbkap: review+
Details | Diff | Review

Description Jesse Ruderman 2011-12-07 13:47:20 PST
Created attachment 579819 [details]
testcase (asserts fatally if pref is set)

1. user_pref("dom.new_bindings", false);
2. Load the testcase

Result:

Assertion failure: !cx->isExceptionPending(), at /builds/slave/m-cen-osx64-dbg/build/js/src/jsinterp.cpp:4781
Comment 1 Jesse Ruderman 2011-12-07 13:47:58 PST
Created attachment 579820 [details]
stack trace
Comment 2 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-12-07 23:01:27 PST
This predates the new DOM binding work, for what it's worth.  It's a regression from bug 633133.  The return value of JS_HasPropertyById is being eaten.
Comment 3 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-12-07 23:04:11 PST
Created attachment 579970 [details] [diff] [review]
Make sure to propagate out failures from JS_HasPropertyById in the old nodelist resolve hook.
Comment 4 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-12-15 11:52:43 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/403c7bcfb42a
Comment 5 Ed Morley [:emorley] 2011-12-16 06:09:43 PST
https://hg.mozilla.org/mozilla-central/rev/403c7bcfb42a

Note You need to log in before you can comment on or make changes to this bug.