"Assertion failure: !cx->isExceptionPending()" with Proxy, old NodeList binding

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
P2
critical
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla11
x86_64
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 579819 [details]
testcase (asserts fatally if pref is set)

1. user_pref("dom.new_bindings", false);
2. Load the testcase

Result:

Assertion failure: !cx->isExceptionPending(), at /builds/slave/m-cen-osx64-dbg/build/js/src/jsinterp.cpp:4781
(Reporter)

Comment 1

6 years ago
Created attachment 579820 [details]
stack trace
This predates the new DOM binding work, for what it's worth.  It's a regression from bug 633133.  The return value of JS_HasPropertyById is being eaten.
Blocks: 633133
Created attachment 579970 [details] [diff] [review]
Make sure to propagate out failures from JS_HasPropertyById in the old nodelist resolve hook.
Attachment #579970 - Flags: review?(mrbkap)
Assignee: nobody → bzbarsky
Priority: -- → P2
Whiteboard: [need review]

Updated

5 years ago
Attachment #579970 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/403c7bcfb42a
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla11

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/403c7bcfb42a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.