708538 - [Gonk] Update the 'b2g' directory with changes since last import

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Philipp von Weitershausen [:philikon]]

vingtetun snuck in a few more changes to the 'b2g' dir since the import.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: Part 1 (v1): Add a local http server on the device at http://localhost:8888

Equivalent of commit https://github.com/cgjones/mozilla-central/commit/fd49e332dcf60b03bed3336675c7d295bbd66a04

Asking cjones for rubberstamping.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js

Equivalent of https://github.com/cgjones/mozilla-central/commit/481bca37d01509fd2ddf74589bd5a45b55c4c6b0

Asking cjones for rubberstamping.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 579981 [details] [diff] [review]
Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js

I don't understand this patch but OK :).

Comment 4

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a972201dc1e
https://hg.mozilla.org/integration/mozilla-inbound/rev/75b6d7b7f6c6

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> Comment on attachment 579981 [details] [diff] [review]
> Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js
> 
> I don't understand this patch but OK :).

setTimeout(function() {}, 0) is often used to get out of the event loop.
In this case it is used to ensure the click event dispatch is finished and so we can start to fire a new mouse events sequence.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Vivien Nicolas (:vingtetun) from comment #5)
> (In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> > Comment on attachment 579981 [details] [diff] [review]
> > Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js
> > 
> > I don't understand this patch but OK :).
> 
> setTimeout(function() {}, 0) is often used to get out of the event loop.
> In this case it is used to ensure the click event dispatch is finished and
> so we can start to fire a new mouse events sequence.

Keep in mind that setTimeout(function() {}, 0) comes with ~5ms delay. Not a big deal though.

Comment 7

[Andreas Gal :gal]

How about postMessage instead?

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1a972201dc1e
https://hg.mozilla.org/mozilla-central/rev/75b6d7b7f6c6

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Andreas Gal :gal from comment #7)
> How about postMessage instead?

I really want to fire events - because of gaia but also because of others that are creating their own UI.

Comment 10

[Andreas Gal :gal]

No, I meant instead of setTimeout(0) send yourself a postmessage. That has no 5ms delay.

Comment 11

[Philipp von Weitershausen [:philikon]]

(In reply to Andreas Gal :gal from comment #10)
> No, I meant instead of setTimeout(0) send yourself a postmessage. That has
> no 5ms delay.

Since this bug is closed already, I filed bug 709469 to investigate this.