Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[Gonk] Update the 'b2g' directory with changes since last import

RESOLVED FIXED in mozilla11

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
mozilla11
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

vingtetun snuck in a few more changes to the 'b2g' dir since the import.
Created attachment 579980 [details] [diff] [review]
Part 1 (v1): Add a local http server on the device at http://localhost:8888

Equivalent of commit https://github.com/cgjones/mozilla-central/commit/fd49e332dcf60b03bed3336675c7d295bbd66a04

Asking cjones for rubberstamping.
Attachment #579980 - Flags: review?(jones.chris.g)
Created attachment 579981 [details] [diff] [review]
Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js

Equivalent of https://github.com/cgjones/mozilla-central/commit/481bca37d01509fd2ddf74589bd5a45b55c4c6b0

Asking cjones for rubberstamping.
Attachment #579981 - Flags: review?(jones.chris.g)
Attachment #579980 - Flags: review?(jones.chris.g) → review+
Comment on attachment 579981 [details] [diff] [review]
Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js

I don't understand this patch but OK :).
Attachment #579981 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a972201dc1e
https://hg.mozilla.org/integration/mozilla-inbound/rev/75b6d7b7f6c6
(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> Comment on attachment 579981 [details] [diff] [review]
> Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js
> 
> I don't understand this patch but OK :).

setTimeout(function() {}, 0) is often used to get out of the event loop.
In this case it is used to ensure the click event dispatch is finished and so we can start to fire a new mouse events sequence.
(In reply to Vivien Nicolas (:vingtetun) from comment #5)
> (In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> > Comment on attachment 579981 [details] [diff] [review]
> > Part 2 (v1): Use setTimeout(..., 0) to send the click event from touch.js
> > 
> > I don't understand this patch but OK :).
> 
> setTimeout(function() {}, 0) is often used to get out of the event loop.
> In this case it is used to ensure the click event dispatch is finished and
> so we can start to fire a new mouse events sequence.

Keep in mind that setTimeout(function() {}, 0) comes with ~5ms delay. Not a big deal though.

Comment 7

6 years ago
How about postMessage instead?

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1a972201dc1e
https://hg.mozilla.org/mozilla-central/rev/75b6d7b7f6c6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(In reply to Andreas Gal :gal from comment #7)
> How about postMessage instead?

I really want to fire events - because of gaia but also because of others that are creating their own UI.

Comment 10

6 years ago
No, I meant instead of setTimeout(0) send yourself a postmessage. That has no 5ms delay.
(Assignee)

Updated

6 years ago
Blocks: 709468
(Assignee)

Updated

6 years ago
Depends on: 709469
(In reply to Andreas Gal :gal from comment #10)
> No, I meant instead of setTimeout(0) send yourself a postmessage. That has
> no 5ms delay.

Since this bug is closed already, I filed bug 709469 to investigate this.
You need to log in before you can comment on or make changes to this bug.