Closed
Bug 708570
Opened 14 years ago
Closed 14 years ago
Make libfreebl depend on libnspr
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox11 fixed)
RESOLVED
FIXED
mozilla12
| Tracking | Status | |
|---|---|---|
| firefox11 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [inbound][qa-])
Attachments
(1 file)
|
874 bytes,
patch
|
ted
:
review+
blassey
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The build default for libfreebl is to not depend on libnspr, which is something that was done for NSS as a system library. This is not something that is needed for Mozilla code. Disabling it avoids libfreebl dlopening() libnspr and resolving a bunch of symbols, and libfreebl going through stub functions for nspr calls.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #579996 -
Flags: review?(ted.mielczarek)
|
||
Updated•14 years ago
|
Attachment #579996 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 579996 [details] [diff] [review]
Make libfreebl depend on nspr
[Approval Request Comment]
It is a dependency of bug 683127.
It caused bug 717906 on m-c, which I'm going to request approval for as well.
Attachment #579996 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Comment 5•14 years ago
|
||
Actually, strictly speaking, bug 683127 is supposed to work without this, but hasn't been tested without.
|
||
Updated•14 years ago
|
Attachment #579996 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 6•14 years ago
|
||
status-firefox11:
--- → fixed
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•