Make libfreebl depend on libnspr

RESOLVED FIXED in Firefox 11

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla12
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed)

Details

(Whiteboard: [inbound][qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The build default for libfreebl is to not depend on libnspr, which is something that was done for NSS as a system library. This is not something that is needed for Mozilla code. Disabling it avoids libfreebl dlopening() libnspr and resolving a bunch of symbols, and libfreebl going through stub functions for nspr calls.
(Assignee)

Comment 1

6 years ago
Created attachment 579996 [details] [diff] [review]
Make libfreebl depend on nspr
Attachment #579996 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

6 years ago
Blocks: 712284
Attachment #579996 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d208399b9194
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/d208399b9194
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Depends on: 717906
(Assignee)

Comment 4

5 years ago
Comment on attachment 579996 [details] [diff] [review]
Make libfreebl depend on nspr

[Approval Request Comment]
It is a dependency of bug 683127.
It caused bug 717906 on m-c, which I'm going to request approval for as well.
Attachment #579996 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 5

5 years ago
Actually, strictly speaking, bug 683127 is supposed to work without this, but hasn't been tested without.
Attachment #579996 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/43ece237bceb
status-firefox11: --- → fixed
Whiteboard: [inbound] → [inbound][qa-]
You need to log in before you can comment on or make changes to this bug.