708674 - Add telemetry probe for Firefox shutdown

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

As requested by product (see https://etherpad.mozilla.org/desktop-responsiveness) add a telemetry probe for Firefox shutdown: from close to visual disappearance to process exited fully.

Comment 1

[Andres Hernandez [:andreshm]]

Attachment: Patch v1

First I tried with observers, but that's not going to work, since telemetry classes are shutdown before the stopwatch should finish.

However, the nsAppStartup already store in a profile file (Telemetry.ShutdownTime.txt) the last shutdown time. So, I'm reading that file and adding the value to a telemetry. But, I'm not sure where this should happen. I'm temporally using nsBrowserGlue.js, but I need some advice on this.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 666067 [details] [diff] [review]
Patch v1

This information is already sent in the telemetry ping explicitly (that's why this file was added to begin with):
http://hg.mozilla.org/mozilla-central/annotate/ed5f37774104/toolkit/components/telemetry/TelemetryPing.js#l141

I think that means there's nothing left to do here.

Comment 3

[Andres Hernandez [:andreshm]]

:O that makes sense. How this bug should be resolved, as WONTFIX?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Let's go with INVALID, someone can reopen if the existing shutdown telemetry isn't sufficient.

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

I don't think this bug was invalid when filed as I'm pretty sure shutdown Telemetry didn't exist at that point in time. However, I do agree that the bug should be resolved at this point.