708723 - nsprpub builds for arm for x86 Android

Status: RESOLVED DUPLICATE of bug 693329

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Thomas G Eaton]

Attachment: moz_x86_android

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Build ID: 20110928224508

Steps to reproduce:

I tried to build Fennec for x86 Android


Actual results:

After fixing other issues to get it to build, it seg faulted after failing to link to the nsprpub library.  


Expected results:

The nsprpub libraries should have been built for x86 Android instead of arm.  Below is a patch that fixes the issue for x86, but it would break the arm build.  After making these changes to configure.in, autoconf needs to be run to generate a new configure script.  Platform flags need to be checked to build correctly for the platform indicated in the mozconfig.

diff -r aa6ad7ab9b43 nsprpub/configure.in
--- a/nsprpub/configure.in	Mon Nov 28 10:34:54 2011 +0000
+++ b/nsprpub/configure.in	Tue Dec 06 08:33:09 2011 -0800
@@ -219,8 +219,8 @@
     STRIP="$android_toolchain"/bin/"$android_tool_prefix"-strip
 
     CPPFLAGS="-I$android_platform/usr/include $CPPFLAGS"
-    CFLAGS="-mandroid -I$android_platform/usr/include -msoft-float -fno-short-enums -fno-exceptions $CFLAGS"
-    CXXFLAGS="-mandroid -I$android_platform/usr/include -msoft-float -fpic -fno-short-enums -fno-exceptions $CXXFLAGS"
+    CFLAGS="-mandroid -I$android_platform/usr/include -fno-short-enums -fno-exceptions $CFLAGS"
+    CXXFLAGS="-mandroid -I$android_platform/usr/include -fpic -fno-short-enums -fno-exceptions $CXXFLAGS"
     LDFLAGS="-mandroid -L$android_platform/usr/lib -Wl,-rpath-link=$android_platform/usr/lib --sysroot=$android_platform $LDFLAGS"
 
     dnl prevent cross compile section from using these flags as host flags
@@ -1232,6 +1232,7 @@
     CXXFLAGS="$CXXFLAGS -Wall"
     MDCPUCFG_H=_linux.cfg
     PR_MD_CSRCS=linux.c
+    PR_MD_ASFILES=os_Linux_x86.s
     MKSHLIB='$(CC) $(DSO_LDOPTS) -o $@'
     DSO_CFLAGS=-fPIC
     DSO_LDOPTS='-shared -Wl,-soname -Wl,$(notdir $@)'
@@ -1241,8 +1242,8 @@
                                    # functions (even when using DWARF2 as the
                                    # debugging format)
     COMPILER_TAG=_glibc
-    CPU_ARCH=arm
-    CPU_ARCH_TAG=_arm
+    CPU_ARCH=x86
+    CPU_ARCH_TAG=_x86
     OS_TARGET=Android
     ;;

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

just to note, we're happy to review and take the patches but its not a priority for the upcoming release

Comment 2

[Wan-Teh Chang]

Attachment: nsprpub/configure.in patch by Thomas G Eaton

This is the patch for nsprpub/configure.in that Thomas G Eaton
included in comment 0.

It is not suitable for checkin because it hardcodes the Android
CPU_ARCH to x86.

Another change is to remove the -msoft-float flag from CFLAGS
and CXXFLAGS.

Comment 3

[Wan-Teh Chang]

This bug seems to be a duplicate of bug 693329.

m_kato: do you have any patch for bug 693329?

Comment 4

[Makoto Kato [:m_kato]]

Yes, dup of bug 693329.