708745 - Fennec gets into a bad state trying to handle opening new tabs via target attributes in anchor tags

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Bret Reckard]

Attachment: Screenshot of broken UI

So, could be a problem with Bugzilla's website, but you can't easily login to Bugzilla via the mobile browser to file a bug.

Steps: use the mobile browser
- Find a crash report on about:crashes
- Click on one of the reports
- Click "report this crash" button
- click/poke the "email address" text box to login

Result:
- UI compacts and keyboard disappears
- Can't login

Expected:
- Normal Login process for a website



Ugly System Dump:

  Application Basics

        Name
        Fennec

        Version
        11.0a1

        User Agent
        Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111207 Firefox/11.0a1 Fennec/11.0a1

        Profile Directory

          Open Containing Folder

        Enabled Plugins

          aboutlugins

        Build Configuration

          about:buildconfig

        Crash Reports

          about:crashes

        Memory Use

          about:memory

  Extensions

        Name

        Version

        Enabled

        ID

        Adblock Plus
        1.3.10
        false
        {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

        Phony
        2.0.2
        false
        [e-mail]

  Modified Preferences

      Name

      Value

        browser.startup.homepage_override.mstone

        extensions.lastAppVersion
        11.0a1

        network.cookie.prefsMigrated
        true

        places.database.lastMaintenance
        1323356877

        places.history.expiration.transient_current_max_pages
        21940

        places.history.expiration.transient_optimal_database_size
        35103866

        privacy.donottrackheader.enabled
        true

  Graphics

        Adapter Description
        Android, Model: 'GT-I9100', Product: 'GT-I9100', Manufacturer: 'samsung', Hardware: 'smdkc210'

        Vendor ID
        0127

        Device ID
        a234

        WebGL Renderer
        ARM -- Mali-400 MP -- OpenGL ES 2.0

        GPU Accelerated Windows
        0. Blocked for your graphics card because of unresolved driver issues.

        AzureBackend
        skia

Comment 1

[Alex Keybl [:akeybl]]

This looks like a text formatting issue on crash-stats. Including

Comment 2

[Alex Keybl [:akeybl]]

Including dbaron*

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

There seems to be multiple issues listed in this bug, may we separate them out?
To confirm on the issues : 

- drop downs cannot be read - dup of bug 706609
- cannot log in : is this because the VKB does not appear when you click in the text field?
- font are too large - dup of bug 705446

Comment 4

[Bret Reckard]

I don't believe this is the correct separation.  Also, what is VKB?  I'll come down to show you Naoki and you can decide :).

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ok, I'll see you tomorrow.  Sorry I didn't reply earlier.  VKB = Virtual Keyboard aka Soft Keyboard aka the keyboard that pops open on the display when you click on a text field.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

STR: 

1. Go to a soccorro crash : http://goo.gl/VNMRV ( https://crash-stats.mozilla.com/report/index/5ffcf6c8-421d-46a2-b18f-be8762111211 )
2. click on "Report this Crash"
3. click in the text field

Expected: VKB (Virtual Keyboard) appears
Actual: web page reverts back in the history to the crash report, view port is broken

Note:
The link clicked is long : https://bugzilla.mozilla.org/enter_bug.cgi?advanced=1&bug_severity=critical&keywords=crash&product=Fennec&op_sys=Linux&rep_platform=arm&&cf_crash_signature=%5B%40%20mozalloc_abort%20%7C%20__swrite%20%7C%20dexDataMapAlloc%5D&short_desc=crash%20mozalloc_abort&&comment=This%20bug%20was%20filed%20from%20the%20Socorro%20interface%20and%20is%20%0D%0Areport%20bp-5ffcf6c8-421d-46a2-b18f-be8762111211%20.%0D%0A%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%20%0D%0A

I am not sure but I suspect buffer overflow.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

This is caused by the link having target="_NEW". I was able to set up a simplified test page at http://people.mozilla.org/~kgupta/bug/708745.html - clicking the link forces a new tab open, which Fennec Native completely mishandles. It renders the new page in the same tab, but has messed-up internal state, so as soon as you try to do anything with the page (like tapping on a text field) it goes back to painting the old page.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Improve support for opening new tabs/windows

Based on my testing this seems to work ok. I'm a bit unsure about what the rules are for opening chrome pages and stuff using window.open. e.g. window.open("about:blank") works for me in desktop FFx but gets blocked in fennec (before it gets to browser.js, I think). I can investigate that further if this code needs to handle privilege issues like that.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 582290 [details] [diff] [review]
Improve support for opening new tabs/windows

I have this same patch (almost identical) in my queue. Looks good to me.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Landed on m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b407ff123b6f

Comment 12

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/b407ff123b6f

Comment 13

[Doug Turner (:dougt)]

backed out

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Re-landed on m-i after testing to verify it doesn't introduce a regression.

https://hg.mozilla.org/integration/mozilla-inbound/rev/7744b924b806

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7744b924b806

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7744b924b806

Comment 17

[Cristian Nicolae (:xti)]

I cannot reproduce this issue on the latest Nightly build. Closing bug as verified fixed on:

Firefox 18.0a1 (2012-09-12)
Device: Galaxy Note
OS: Android 4.0.4