708812 - Add investigate and add telemetry probes for android startup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Doug Turner (:dougt)]

As part of https://wiki.mozilla.org/Program_Management/Programs/Telemetry/Probe_Implementation, we should investigate what probes make sense to add.

For example, right now we don't know how fennec is typically started (is it started via a icon click, or another activity ask us to open a url), we also don't know how much time is spent in java-android specific code before we load libxul.  I am sure there are others..

Comment 2

[JP Rosevear [:jpr]]

I think this should be a P2, I wouldn't stop ship, but I think this data will really inform us.

Comment 3

[Doug Turner (:dougt)]

i am not working on these right now.  resetting assignee.

Comment 4

[JP Rosevear [:jpr]]

Spent a few minutes discussing with Madhava today.  Type of launch maybe interesting if we can distinguish between a regular external link and a launch via the google search widget.  As well, potentially correlating direct app launch to immediate next step (ie bookmark, search, history) would be useful.  Test pilot study was what Madhava was thinking for this, but if we can figure out a way to do this in telemetry, it would be cheaper and faster.

Comment 5

[(dormant account)]

(In reply to JP Rosevear [:jpr] from comment #4)
> Spent a few minutes discussing with Madhava today.  Type of launch maybe
> interesting if we can distinguish between a regular external link and a
> launch via the google search widget.  As well, potentially correlating
> direct app launch to immediate next step (ie bookmark, search, history)
> would be useful.  Test pilot study was what Madhava was thinking for this,
> but if we can figure out a way to do this in telemetry, it would be cheaper
> and faster.

Telemetry is fine for all of the above.

Comment 6

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Telemetry for startup performance.

Add telemetry for the most important startup performance metrics:
- Java UI ready
- about:home topsites filled in
- Gecko ready

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 2. Telemetry for startup action.

Add telemetry to see if we did an icon startup, or an external URL startup. For the latter, also track how often we can prefetch/redirect.

Comment 8

[Dão Gottwald [:dao]]

In order to avoid future confusion and possible conflicts, could you please get into the habit of using a common prefix for Fennec-specific histograms? Desktop Firefox uses FX_.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 665933 [details] [diff] [review]
Patch 2. Telemetry for startup action.

Review of attachment 665933 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +126,5 @@
>  
> +    private static enum StartupAction {
> +        NORMAL,     /* normal application start */
> +        URL,        /* launched with a passed URL */
> +        PREFECTH,   /* launched with a passed URL that we prefetch */

PREFETCH

Comment 10

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56a268d63e01
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d8822b9c0b5

Comment 11

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d17c811e3b8c for everyone's favorite obscure failure - in https://tbpl.mozilla.org/php/getParsedLog.php?id=15707702&tree=Mozilla-Inbound where you hit "[JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITelemetry.getHistogramById]" {file: "chrome://browser/content/browser.js" line: 6731}]," that makes the run fail (or more accurately, marks the run as having failed).

Comment 12

[Nathan Froyd [:froydnj]]

Comment on attachment 665929 [details] [diff] [review]
Patch 1. Telemetry for startup performance.

Review of attachment 665929 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +1444,5 @@
>      {
>          GeckoAppShell.registerGlobalExceptionHandler();
>  
> +        // The clock starts...now. Better hurry!
> +        mJavaUiStartupTimer = new Telemetry.Timer("STARTUP_TIME_JAVACHROME");

So here you have STARTUP_TIME_JAVACHROME...

::: toolkit/components/telemetry/Histograms.json
@@ +2235,5 @@
>      "n_buckets": 20,
>      "description": "Number of history entries in the original XUL places database",
>      "cpp_guard": "ANDROID"
>    },
> +  "STARTUP_TIME_JAVAUI": {

...and here you call it STARTUP_TIME_JAVAUI.  That's not going to end well.

Comment 13

[Gian-Carlo Pascutto [:gcp]]

Now with less copypasta errors:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2fa7360a9e3
https://hg.mozilla.org/integration/mozilla-inbound/rev/ece3e81be2b6

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2fa7360a9e3
https://hg.mozilla.org/mozilla-central/rev/ece3e81be2b6