708893 - Pan move events are ignored after releasing pinch zoom finger

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Load timecube.com.
2. Pinch zoom wildly with two fingers.
3. Release ONE finger!
4. Pan with the OTHER finger that is still down.

RESULT:
1. The page does not pan until you release the other finger.
2. logcat dumps lots of error messages about "impossible" move events that Fennec is ignoring:

E/GeckoPanZoomController( 5681): Received impossible touch move while in FLING
E/GeckoPanZoomController( 5681): Received impossible touch move while in FLING
E/GeckoPanZoomController( 5681): Received impossible touch move while in FLING
E/GeckoPanZoomController( 5681): Received impossible touch move while in FLING
E/GeckoPanZoomController( 5681): Received impossible touch move while in NOTHING
E/GeckoPanZoomController( 5681): Received impossible touch move while in NOTHING
E/GeckoPanZoomController( 5681): Received impossible touch move while in NOTHING
E/GeckoPanZoomController( 5681): Received impossible touch move while in NOTHING
E/GeckoPanZoomController( 5681): Received impossible touch move while in NOTHING
E/GeckoPanZoomController( 5681): Received impossible touch move while in NOTHING
E/GeckoPanZoomController( 5681): Received impossible touch end while in NOTHING

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Allow panning after removing one finger from pinch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The patch also gets rid of the "impossible touch move" errors because we don't incorrectly go into FLING and NOTHING via bounce() even though the user still has one finger down.

Comment 3

[Patrick Walton (:pcwalton)]

Comment on attachment 581778 [details] [diff] [review]
Allow panning after removing one finger from pinch

Review of attachment 581778 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Landed on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bd7bf20c046

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5bd7bf20c046

Comment 6

[Carla Nadastean]

Retested with: 
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111220 Firefox/11.0a1 Fennec/11.0a1

Bug no longer reproducible. Panning is working properly for the described scenario.
Verifying bug.