Closed Bug 708996 Opened 13 years ago Closed 13 years ago

JIT failure in Float4Matrix tests (marix initialization for scaling)

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P2)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Q2 12 - Cyril

People

(Reporter: virgilp, Unassigned)

References

Details

Attachments

(2 files)

reduced testcase that exposes the issue
817 bytes, text/plain
Details
bugfix
3.77 KB, patch
lhansen
: review+
edwsmith
: superreview+
Details | Diff | Splinter Review 
See attachment for a testcase that can run in the shell
Bug is most likely due to float4 inlining

Expected results:
2,0,0,0
0,3,0,0
0,0,0.4000000059604645,0
0,0,0,1

Actual results:
2,0,0,0
0,3,0,0
0,3,0,0
0,0,0,1
Root cause appers to be CSE for LIR_ffff2f4
Not CSE afterall (even though it worked with -Dnocse), but improper code generation in Nativei386 (which was copied to NativeX64 too).
Blocks: float/float4
Priority: -- → P2
Target Milestone: --- → Q2 12 - Cyril
Attached patch bugfix — — Splinter Review 
Added patch in case someone feels like reviewing this issue.
Attachment #580357 - Flags: superreview?(edwsmith)
Attachment #580357 - Flags: review?(lhansen)
fixed in changeset 7055:1747a2dd963a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #580357 - Flags: superreview?(edwsmith) → superreview+
Comment on attachment 580357 [details] [diff] [review]
bugfix

Rubber stamp.  My expertise in the Assembler and areas below it is virtually zero.
Attachment #580357 - Flags: review?(lhansen) → review+
changeset: 7147:0814059d4ff7
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 708996: add testcase that exposed issue

http://hg.mozilla.org/tamarin-redux/rev/0814059d4ff7
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: