JIT failure in Float4Matrix tests (marix initialization for scaling)

VERIFIED FIXED in Q2 12 - Cyril

Status

P2
normal
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: virgilp, Unassigned)

Tracking

unspecified
Q2 12 - Cyril
Bug Flags:
in-testsuite +

Details

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Created attachment 580351 [details]
reduced testcase that exposes the issue

See attachment for a testcase that can run in the shell
Bug is most likely due to float4 inlining

Expected results:
2,0,0,0
0,3,0,0
0,0,0.4000000059604645,0
0,0,0,1

Actual results:
2,0,0,0
0,3,0,0
0,3,0,0
0,0,0,1
(Reporter)

Comment 1

7 years ago
Root cause appers to be CSE for LIR_ffff2f4
(Reporter)

Comment 2

7 years ago
Not CSE afterall (even though it worked with -Dnocse), but improper code generation in Nativei386 (which was copied to NativeX64 too).
(Reporter)

Updated

7 years ago
Blocks: 613140
Priority: -- → P2
Target Milestone: --- → Q2 12 - Cyril
(Reporter)

Comment 3

7 years ago
Created attachment 580357 [details] [diff] [review]
bugfix

Added patch in case someone feels like reviewing this issue.
Attachment #580357 - Flags: superreview?(edwsmith)
Attachment #580357 - Flags: review?(lhansen)
(Reporter)

Updated

7 years ago
See Also: → bug 707981
(Reporter)

Comment 4

7 years ago
fixed in changeset 7055:1747a2dd963a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Attachment #580357 - Flags: superreview?(edwsmith) → superreview+

Comment 5

7 years ago
Comment on attachment 580357 [details] [diff] [review]
bugfix

Rubber stamp.  My expertise in the Assembler and areas below it is virtually zero.
Attachment #580357 - Flags: review?(lhansen) → review+

Comment 6

7 years ago
changeset: 7147:0814059d4ff7
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 708996: add testcase that exposed issue

http://hg.mozilla.org/tamarin-redux/rev/0814059d4ff7

Updated

7 years ago
Status: RESOLVED → VERIFIED
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.