Closed
Bug 709083
Opened 12 years ago
Closed 12 years ago
DoneCreatingElement for button called in the wrong place
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: hsivonen, Assigned: hsivonen)
Details
Attachments
(2 files)
5.24 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
1.21 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
DoneCreatingElement should be called after adding all attributes. It's now called after adding all children.
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 585673 [details] [diff] [review] Move DoneCreatingElement r=me. Sorry for the lag.....
Attachment #585673 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Thanks for the r+. Landed. https://hg.mozilla.org/integration/mozilla-inbound/rev/3335984ce688
Comment 4•12 years ago
|
||
And backed out, because it turned Android mochitest-8 orange: https://hg.mozilla.org/integration/mozilla-inbound/rev/8f2ca4c209e4
Assignee | ||
Comment 5•12 years ago
|
||
Android-specific XBL seems to be interfering with the Mochitest added here: 1263 INFO TEST-START | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html 1264 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html | an unexpected uncaught JS exception reported through window.onerror - this.clickToPlay is null at chrome://global/content/bindings/videocontrols.xml:1230 1265 INFO TEST-PASS | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html | Should be muted already. 1266 INFO TEST-END | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html | finished in 5151ms
Assignee | ||
Comment 6•12 years ago
|
||
So the mochitest added here failed in Fennec XUL. Would it be OK to make the test exit early in Fennec XUL considering that Fennec XUL is not in focus anymore?
Comment 7•12 years ago
|
||
Yeah, I think so.
Assignee | ||
Comment 8•12 years ago
|
||
I couldn't find a way to check for Fennec XUL specifically in a makefile.
Attachment #607111 -
Flags: review?(bzbarsky)
Comment 9•12 years ago
|
||
Comment on attachment 607111 [details] [diff] [review] Exclude the test from Fennec r=me if you add a comment with a bug number about this (and of course file said bug).
Attachment #607111 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 10•12 years ago
|
||
Thanks. Filed bug 737020. Relanded https://hg.mozilla.org/integration/mozilla-inbound/rev/cfbacfc02abd https://hg.mozilla.org/integration/mozilla-inbound/rev/32e7b965ddb5
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cfbacfc02abd https://hg.mozilla.org/mozilla-central/rev/32e7b965ddb5
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•