709083 - DoneCreatingElement for button called in the wrong place

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Henri Sivonen (:hsivonen)]

DoneCreatingElement should be called after adding all attributes. It's now called after adding all children.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Move DoneCreatingElement

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 585673 [details] [diff] [review]
Move DoneCreatingElement

r=me.  Sorry for the lag.....

Comment 3

[Henri Sivonen (:hsivonen)]

Thanks for the r+. Landed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3335984ce688

Comment 4

[Jonathan Kew [:jfkthame]]

And backed out, because it turned Android mochitest-8 orange:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f2ca4c209e4

Comment 5

[Henri Sivonen (:hsivonen)]

Android-specific XBL seems to be interfering with the Mochitest added here:
1263 INFO TEST-START | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html
1264 ERROR TEST-UNEXPECTED-FAIL | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html | an unexpected uncaught JS exception reported through window.onerror - this.clickToPlay is null at chrome://global/content/bindings/videocontrols.xml:1230
1265 INFO TEST-PASS | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html | Should be muted already.
1266 INFO TEST-END | /tests/parser/htmlparser/tests/mochitest/test_bug709083.html | finished in 5151ms

Comment 6

[Henri Sivonen (:hsivonen)]

So the mochitest added here failed in Fennec XUL. Would it be OK to make the test exit early in Fennec XUL considering that Fennec XUL is not in focus anymore?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yeah, I think so.

Comment 8

[Henri Sivonen (:hsivonen)]

Attachment: Exclude the test from Fennec

I couldn't find a way to check for Fennec XUL specifically in a makefile.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 607111 [details] [diff] [review]
Exclude the test from Fennec

r=me if you add a comment with a bug number about this (and of course file said bug).

Comment 10

[Henri Sivonen (:hsivonen)]

Thanks. Filed bug 737020.

Relanded
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfbacfc02abd
https://hg.mozilla.org/integration/mozilla-inbound/rev/32e7b965ddb5

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/cfbacfc02abd
https://hg.mozilla.org/mozilla-central/rev/32e7b965ddb5