709149 - [wo] Search engine setup for Firefox for Wolof.

Status: RESOLVED INCOMPLETE

(Mozilla Localizations :: wo / Wolof, defect)

Description

[Axel Hecht [:Pike]]

We want to ship Firefox with a good list of search engines for Wolof. 

We're going to work towards this in three phases. First, the localization team and Milos (Milos Dinic) will look at the market for the language and come up with a good set of search providers. Dominique, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Firefox/Productization>. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo!, Bing, Amazon, eBay, Wikipedia

After we decided on a particular search engine, Milos will contact the owner and ask for permission, and for specifics like proper search flags. Dominique, we'll likely need your help to at least get the contact information.

Once we have a specification on what the searchengines for Wolof should look like, the localization team and Milos will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Milos. After a successful review, the localization team will land them.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Stas, Axel or someone else appointed by Milos. The data here is sensitive to users and our search partners, thus the extra care here.

The Wolof team will be driving this bug to completion.

Comment 1

[Milos Dinic [:Milos]]

Hey Dominique,

Do you have any ideas about this?

Comment 2

[Michael Bauer]

I've been asked to help out with this one. The intention is (for now) to ship with only two localized search engines:
http://www.google.com/webhp?hl=wo
http://wo.wikipedia.org

The others can remain as the default ones which are normally shipped.

Comment 3

[Milos Dinic [:Milos]]

That seems OK for now. So, the current search engines list we're willing to go out with is:

Google, Yahoo!, Bing, Amazon, eBay, Wikipedia(wo)? What about adding twitter? Would that mean to users of Firefox in Wolof?

Now, to do this, we need to change one file(browser/searchengines/list.txt) and add one file, as well(wikipedia-wo.xml). Former should be reflecting search engines, and for the said list, it should look something like:

amazondotcom
bing
eBay
google
wikipedia-wo
yahoo

(note that ordering of the searchengines goes into region.properties file).

For all the searchplugins we don't have localized in Wolof(all except Wikipedia and Google), we don't need to create search plugins, as they're gonna be copied over from en-US.

For Google, we don't need to do anything, as well, as that's already dealt with, as well.

Now, for Wikipedia in Wolof, we'll need to code a Open Search Plugin. Please take a look at https://developer.mozilla.org/en-US/docs/Creating_OpenSearch_plugins_for_Firefox and a good example of a search plugin: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bs/raw-file/tip/browser/searchplugins/wikipedia-bs.xml

Comment 4

[Michael Bauer]

Considering the time we have left, let's just park Twitter for now and figure that out at our leisure once we're in the normal release cycle.

Comment 5

[Axel Hecht [:Pike]]

To clarify, google has asked us to not special case the searchplugins per locale, so instead of hardcoding http://www.google.com/webhp?hl=wo, we'd use the standard search and rely on accept-language headers and geolocation to return the right combination of UI language and results. I'd rather not change that unless we hit some tough rocks on the way.

Comment 6

[Michael Bauer]

That's fine, so that just leaves the Wikipedia one. Milos, any chance of you creating that plugin patch? I think that would be by the far the quickest and least aggravating way for everyone ;)

Comment 7

[Michael Bauer]

Attachment: wikipedia search plugin patch

Ok I modelled this patch on the Gaelic one, I hope it's ok. Could somone please check and if it's ok, commit and close this bug so we can move for a signoff of the Wolof translations? Thanks!

Comment 8

[Milos Dinic [:Milos]]

Comment on attachment 656873 [details] [diff] [review]
wikipedia search plugin patch

Akerbeltz,

in order to see what's going to be committed exactly, we like seeing patches instead of files. That said, you'd want to create that file in the local copy of wo hg clone, hg add the file, and then do a "hg diff > mypatch.diff" command. That will create a mypatch.diff file, which you should upload here, and then flag em for a review.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 656873 [details] [diff] [review]
wikipedia search plugin patch

We'll also need the change to list.txt, which would be in that patch together.

Comment 10

[Dwayne Bailey]

Michael if you can send me the files I'll make and add the patch here for review.

Comment 11

[Dwayne Bailey]

Attachment: Wolof seachplugins

I've created this patch based on the conversation in this bug.  The Wikipedia WO XML is taken from the last attachment by Michael (I haven't checked it apart from diffing against FR where I didn't see anything to worry me)

Comment 12

[Milos Dinic [:Milos]]

Comment on attachment 657802 [details] [diff] [review]
Wolof seachplugins

Review of attachment 657802 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/searchplugins/wikipedia-wo.xml
@@ +1,1 @@
> +rchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">

"rchPlugin " is wrong :) So, just <SearchPlugin " instead of that, and we're good to go.

Comment 13

[Dwayne Bailey]

Attachment: Wolof seachplugins

Whoops that was strange.  New patch fixes the broken tag

Comment 14

[Milos Dinic [:Milos]]

Comment on attachment 670549 [details] [diff] [review]
Wolof seachplugins

Review of attachment 670549 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, r+.

Comment 15

[Milos Dinic [:Milos]]

Dwayne,

please go ahead and commit this patch and push to aurora and beta.

Comment 16

[Pascal Chevrel:pascalc]

Milos, Dwayne, what is the status of this bug?

Comment 17

[Dwayne Bailey]

Khaled is looking at the patch and will make a commit ASAP

Comment 18

[Axel Hecht [:Pike]]

We have put the effort to ship Firefox in Wolof on hold, thus resolving this bug as INCOMPLETE.

If we decide to resume the effort, we should file new bugs.