Closed Bug 709205 Opened 8 years ago Closed 8 years ago

use services::GetObserverService instead of do_GetService


(Core :: General, defect)

Not set





(Reporter: froydnj, Assigned: froydnj)



(3 files, 1 obsolete file)

Several do_GetService(NS_OBSERVERSERVICE_CONTRACTID) calls have snuck in over time; the incoming patches replace them with their equivalent, mozilla::services::GetObserverService.  There are still a couple two-argument do_GetService(NS_OBSERVERSERVICE_CONTRACTID, &rv) calls lying about; I chose not to handle those in this patchset.
Simple patch for docshell and dom.
Attachment #580484 - Flags: review?(bzbarsky)
Attached patch use GetObserverService in places (obsolete) — Splinter Review
Simple patch for places.
Attachment #580485 - Flags: review?(mak77)
Simple patch for xpcom.
Attachment #580486 - Flags: review?(doug.turner)
Comment on attachment 580484 [details] [diff] [review]
use GetObserverService in docshell, dom

Attachment #580484 - Flags: review?(bzbarsky) → review+
Attachment #580486 - Flags: review?(doug.turner) → review+
Comment on attachment 580485 [details] [diff] [review]
use GetObserverService in places

Review of attachment 580485 [details] [diff] [review]:

In both places you may use just services:: since those files already have using namespace mozilla;
Attachment #580485 - Flags: review?(mak77) → review+
Adjusted to account for mak's comments and drive-by-fixes to other mozilla::services:: instances in the touched files.  Mak approved the drive-by-fixes on IRC.  Carrying over r+.
Attachment #580485 - Attachment is obsolete: true
Attachment #582296 - Flags: review+
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.