use services::GetObserverService instead of do_GetService

RESOLVED FIXED in mozilla11

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla11
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Several do_GetService(NS_OBSERVERSERVICE_CONTRACTID) calls have snuck in over time; the incoming patches replace them with their equivalent, mozilla::services::GetObserverService.  There are still a couple two-argument do_GetService(NS_OBSERVERSERVICE_CONTRACTID, &rv) calls lying about; I chose not to handle those in this patchset.
(Assignee)

Comment 1

6 years ago
Created attachment 580484 [details] [diff] [review]
use GetObserverService in docshell, dom

Simple patch for docshell and dom.
Attachment #580484 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

6 years ago
Created attachment 580485 [details] [diff] [review]
use GetObserverService in places

Simple patch for places.
Attachment #580485 - Flags: review?(mak77)
(Assignee)

Comment 3

6 years ago
Created attachment 580486 [details] [diff] [review]
use GetObserverService in xpcom

Simple patch for xpcom.
Attachment #580486 - Flags: review?(doug.turner)
Comment on attachment 580484 [details] [diff] [review]
use GetObserverService in docshell, dom

r=me
Attachment #580484 - Flags: review?(bzbarsky) → review+

Updated

6 years ago
Attachment #580486 - Flags: review?(doug.turner) → review+
Comment on attachment 580485 [details] [diff] [review]
use GetObserverService in places

Review of attachment 580485 [details] [diff] [review]:
-----------------------------------------------------------------

In both places you may use just services:: since those files already have using namespace mozilla;
Attachment #580485 - Flags: review?(mak77) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 582296 [details] [diff] [review]
use GetObserverService in places

Adjusted to account for mak's comments and drive-by-fixes to other mozilla::services:: instances in the touched files.  Mak approved the drive-by-fixes on IRC.  Carrying over r+.
Attachment #580485 - Attachment is obsolete: true
Attachment #582296 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f8dd0388d87
https://hg.mozilla.org/integration/mozilla-inbound/rev/da1b38aa2886
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbd797fc4d7f
Flags: in-testsuite?
Keywords: checkin-needed
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/8f8dd0388d87
https://hg.mozilla.org/mozilla-central/rev/da1b38aa2886
https://hg.mozilla.org/mozilla-central/rev/cbd797fc4d7f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.