relative STRINGSPATH in mobile/android/base/locales is broken

RESOLVED FIXED

Status

()

Firefox for Android
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 580527 [details] [diff] [review]
patch

I've been seeing this:

host-6-229:locales blassey$ make
updating mobile/android/base/locales/Makefile
/Users/blassey/src/mozilla-central/objdir-droid/config/nsinstall -D ../res/values
/opt/local/bin/python2.7 ../../../../../config/Preprocessor.py -DAB_CD=en-US -DOSTYPE=\"Linux\" -DOSARCH=Linux \
	  -DBRANDPATH="/Users/blassey/src/mozilla-central/objdir-droid/mobile/android/base/locales/../../../../dist/bin/chrome/en-US/locale/branding/brand.dtd" \
	  -DSTRINGSPATH="../../../../../mobile/android/base/locales/en-US/android_strings.dtd" \
	  ../../../../../mobile/android/base/locales/../strings.xml.in \
	  > ../res/values/strings.xml
Traceback (most recent call last):
  File "../../../../../config/Preprocessor.py", line 477, in <module>
    main()
  File "../../../../../config/Preprocessor.py", line 462, in main
    pp.handleCommandLine(None, True)
  File "../../../../../config/Preprocessor.py", line 168, in handleCommandLine
    self.do_include(f)
  File "../../../../../config/Preprocessor.py", line 447, in do_include
    self.handleLine(l)
  File "../../../../../config/Preprocessor.py", line 230, in handleLine
    cmd(args)
  File "../../../../../config/Preprocessor.py", line 456, in do_includesubst
    self.do_include(args)
  File "../../../../../config/Preprocessor.py", line 430, in do_include
    raise Preprocessor.Error(self, 'FILE_NOT_FOUND', str(args))
__main__.Error: ('/Users/blassey/src/mozilla-central/mobile/android/base/strings.xml.in', 5, 'FILE_NOT_FOUND', '/Users/blassey/src/mozilla-central/mobile/android/base/../../../../../mobile/android/base/locales/en-US/android_strings.dtd')
make: *** [../res/values/strings.xml] Error 1
make: *** Deleting file `../res/values/strings.xml'

Making STRINGSPATH an absolute path fixes this for me
Attachment #580527 - Flags: review?(khuey)

Comment 1

7 years ago
https://hg.mozilla.org/mozilla-central/rev/f5d0e8d72b9b
Assignee: nobody → blassey.bugs
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.