709384 - "ASSERTION: Don't schedule the same document multiple times"

Status: RESOLVED FIXED

Description

[Jesse Ruderman]

Created attachment 580578 [details]
testcase

###!!! ASSERTION: Don't schedule the same document multiple times: 'mFrameRequestCallbackDocs.IndexOf(aDocument) == mFrameRequestCallbackDocs.NoIndex', file layout/base/nsRefreshDriver.cpp, line 533

Comment 1

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Worksforme with an m-c debug build pulled today (on Mac).

Comment 2

[Jesse Ruderman]

I can reproduce with the same rev (built from http://hg.mozilla.org/mozilla-central/rev/63bff373cb94). Hmm. I'm on Mac OS X 10.6, if that matters.

Comment 3

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

I am too...  I guess I'll try building from your rev and reproducing.  Using a clean profile?

Comment 4

[Jesse Ruderman]

I can reproduce with a clean profile. (Tested with rev 7e74a12601a4 this time.)

Comment 5

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

OK, now I can reproduce; I needed a narrower browser window to trigger tab scrolling.  This is totally my fault: canceling a callback doesn't unregister us (on purpose, sorta), but other code depends on the invariant that registered == have callbacks.

Comment 6

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

Created attachment 581883 [details] [diff] [review]
Manage our scheduled state better when animation frame requests are canceled.

Comment 7

[Boris Zbarsky [:bz] (vacation Aug 14-27)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb0d7445611

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/3eb0d7445611