709402 - Form history repository layer

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Comment 1

[Richard Newman [:rnewman]]

Will depend on a Fennec content provider.

Comment 2

[Richard Newman [:rnewman]]

Part 1:

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a555fb12c22

Comment 3

[Richard Newman [:rnewman]]

Attachment: Stub for Aurora approval.

Routine Sync approval for Aurora.

Comment 4

[Richard Newman [:rnewman]]

Nick's test procedure:

For reference, this is my test procedure:

 * Test Fennec -> Desktop
   - Add new form item in Fennec
   - Sync device, Sync desktop, check appears on Desktop
   - Delete form item in Fennec
   - Sync device, Sync desktop, check item no longer appears on Desktop, and is not revived in Fennec
     * THIS DOES NOT WORK
     * Instead, check that server has correct deleted record (using Dump the cleartext of each record in a collection
       to the console. from https://wiki.mozilla.org/Services/Sync/Snippets)
   - Sync device again, check that record is not revived in Fennec
 * Test Desktop -> Fennec
   - Add new form item in Desktop
   - Sync desktop, Sync device, check appears in Fennec
   - Delete form item in Desktop
   - Sync desktop, Sync device, check item no longer appears in Fennec, and is not revived in Desktop
 * Test reconcile same
   - Add new form item in Desktop
   - Add same form item in Fennec with same form value
   - Sync desktop, then sync device
   - Check single form item with Desktop GUID appears in Fennec and Desktop, and has Desktop's form value in both
 * Test reconcile different
   - Add new form item in Desktop
   - Add same form item in Fennec with different form value
   - Sync desktop, then sync device
   - Check two form items appear in Fennec and Desktop

Comment 5

[Ed Morley [:emorley]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Part 1:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/5a555fb12c22

https://hg.mozilla.org/mozilla-central/rev/5a555fb12c22

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 608782 [details]
Stub for Aurora approval.

[Triage Comment]
If these changes are mobile-only and are not dependent upon the Maple uplift to Aurora, a=akeybl for Aurora 13.

Comment 7

[Allison Naaktgeboren :ally]

work for this is on github, and is progressing there.

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9638f8e27e00

Comment 9

[Richard Newman [:rnewman]]

Note that this is preffed off (well, hard-coded disabled) by design: this'll have a big performance impact until batching lands.

When I find the bug number for that, I'll set the appropriate dependencies and file a follow-up to pref on.

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/9638f8e27e00

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bf8c6122a969