Closed Bug 709432 Opened 8 years ago Closed 8 years ago

BrowserProvider overwrites provided GUIDs

Categories

(Firefox for Android :: General, defect, P1)

All
Android
defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: rnewman, Unassigned)

References

Details

Attachments

(1 file)

… unconditionally. This makes Sync a little harder :D

The attached patch is pretty trivial, but untested.

Throwing this at blassey, but I'd be happy with any peer to review it.
Attachment #580610 - Flags: review?(blassey.bugs)
Tree is closed right now, so I've asked jvoll to just work with this in his local build so he's unblocked. But this is blocking our local DB repo for bookmarks.
Comment on attachment 580610 [details] [diff] [review]
Proposed patch. v1

Review of attachment 580610 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/BrowserProvider.java
@@ +929,5 @@
>                  History.URL + " IS NOT NULL)";
>  
>          return db.delete(TABLE_IMAGES, selection, null);
>      }
> +}

not sure if you added or removed the new line here, just make sure its the former
Attachment #580610 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/5c64fb241d4e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.