BrowserProvider overwrites provided GUIDs

RESOLVED FIXED

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: rnewman, Unassigned)

Tracking

unspecified
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 580610 [details] [diff] [review]
Proposed patch. v1

… unconditionally. This makes Sync a little harder :D

The attached patch is pretty trivial, but untested.

Throwing this at blassey, but I'd be happy with any peer to review it.
Attachment #580610 - Flags: review?(blassey.bugs)
(Reporter)

Comment 1

6 years ago
Tree is closed right now, so I've asked jvoll to just work with this in his local build so he's unblocked. But this is blocking our local DB repo for bookmarks.
Comment on attachment 580610 [details] [diff] [review]
Proposed patch. v1

Review of attachment 580610 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/db/BrowserProvider.java
@@ +929,5 @@
>                  History.URL + " IS NOT NULL)";
>  
>          return db.delete(TABLE_IMAGES, selection, null);
>      }
> +}

not sure if you added or removed the new line here, just make sure its the former
Attachment #580610 - Flags: review?(blassey.bugs) → review+
(Reporter)

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/5c64fb241d4e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.