709449 - If .msf file for parent IMAP folder is suffixed(X-suffix.msf for folder of X), .msf file for search folder is created under wrong .sbd directory without suffix(under x.sbd instead of proper X-suffix.sbd) even though X-suffix.msf is used for IMAP folder X)

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[WADA:World Anti-bad-Duping Agency]

If .msf file for parent IMAP folder is suffixed(X-1.msf, X-2.msf etc.), search folder is created in wrong .sbd directory without suffix(x.sbd).

This is spin-off of bug 707730 comment #18.

[Steps to reproduce]

(1) IMAP folder uses suffixed .msf file(e.g. X-1.msf for folder X).
    This occurs by next on Win/NTFS;
    (1-A) Server supports case insensitive folder name.
          Create IMAP folder "a b" => "a b.msf" is used by Tb.
          Create IMAP folder "A B" => "A B-1.msf" is used by Tb.
          On Win, file of "A B.msf" == file of "a b.msf", so suffix is added.
          If "A b"   is created after above, "A b-2.msf  " is used.
          If "A B-1" is created after above, "A B-1-1.msf" is used.
    (1-B) By bug 520437. 
          Create folder "A B", Unsubscribe "A B", and Subscribe "A B" again.
    (1-C) Copy profile, restart Tb using copied profile in offline mode
          (==server is unreachiable), and restart Tb again, access IMAP server.
    So, folders of suffixed .msf name were created using Yahoo! IMAP
    who supports case sensitive mbox name.
      "a b" : uses file of "a b.msf"
      "A b" : uses file of "A b-1.msf" instead of "A b.msf" (A b==a b on Win)
      "A B" : uses file of "A B-2.msf" instead of "A B.msf" (A B==a b on Win)
(2) Create MAP folder "Sub" under IMAP folder of "a b", "A b", "A B".
    => "Sub.msf is created under "a b.sbd", as expected.
    => "Sub.msf is created under "A b-1.sbd", as expected.
    => "Sub.msf is created under "A B-2.sbd", as expected.
(3) Create search folder "bla bla" under IMAP folder of "A B".
    => "bla.bla.msf is created under "a b.sbd".
    => uri=imap://[e-mail]/A B/bla%20bla
(4) Create search folder "bla bla" under IMAP folder of "a a", "A a".
    => Existent "bla.bla.msf" under "a b.sbd" is shared.
(5) Update search rule at "bla bla" under one of "a a", "A b", "A B".
    => Rule of "bla bla" under other parent folder is also changed,
       because "bla bla.msf" under "a b.sbd" is shared.
(6) Continued test, tried rename to "xx bla bla", rename back to "bla bla",
    search folder access, update of search rules and so on.
    => Exception on click of "bla bla", cleared search criteria at Properties
       of "bla bla", no entry for "bla bla" in virtualFolders.dat,
       etc. happened.
(7) Terminate Tb => no entry for "bla bla" under "a b", "A b", "A B"  was
    written in virtualFolders.dat. Perhaps due to exception (6).
(8) Restart of Tb => due to (7), any of "bla bla" is lost.

Comment 1

[WADA:World Anti-bad-Duping Agency]

Why Security-Sensitive bug? I checked it by mistake upon bug open?
Can some one remove security flag?

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 709449 - Derive new IMAP subfolder paths from their parent. r=#thunderbird-reviewers

IMAP folder URIs can differ from their on-disk paths when summary files have
numeric collision suffixes. This caused virtual-folder summaries to use the
wrong .sbd directory.

Set the child path from the parent’s actual filesystem path. Test creation and
movement of virtual folders beneath a suffixed parent, also covering
bug 2009626.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2647c57eed25
Derive new IMAP subfolder paths from their parent. r=mkmelin