Closed Bug 709485 Opened 8 years ago Closed 8 years ago

Regression: Tablet UI browser does not resize correctly after toggling sidebar

Categories

(Firefox for Android Graveyard :: General, defect)

Firefox 10
defect
Not set

Tracking

(firefox9 unaffected, firefox10 fixed, firefox11 fixed)

VERIFIED FIXED
Firefox 11
Tracking Status
firefox9 --- unaffected
firefox10 --- fixed
firefox11 --- fixed

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch patchSplinter Review
Steps to reproduce:
1. Open XUL Fennec in landscape mode on a Honeycomb tablet.
2. If the tab sidebar is not visible, drag or tap to show it.
3. Drag the sidebar to hide it.
4. Tap the tabs button in the toolbar to show the sidebar.

Actual results: The tab sidebar appears, but the browser and actionbar do not resize so they are pushed off the edge of the screen.

This is a regression from bug 692357.  It happens because TabletSidebar.grab() tells the browser sizing code to ignore the the sidebar, but ungrab() does not always tell it to stop ignoring.  This one-line change to TabletSidebar.hide() ensures that we stop ignoring the sidebar no matter which code path we take in ungrab().
Attachment #580655 - Flags: review?(mark.finkle)
Attachment #580655 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/ee96343f8e13
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Comment on attachment 580655 [details] [diff] [review]
patch

Requesting approval for Aurora 10.  This is a one-line, mobile-only fix for a user-visible regression in update 10.  The fix is safe and has very low regression potential.
Attachment #580655 - Flags: approval-mozilla-aurora?
Attachment #580655 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:10.0)Gecko/20111228
Firefox/10.0 Fennec/10.0
Devices: Asus EEE Transformer
OS: Android 3.2.1
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.