Last Comment Bug 709486 - "Warning: Ignoring obsolete chrome registration modifier 'xpcnativewrappers=no'" message in error console should not contain the prefix "Warning"
: "Warning: Ignoring obsolete chrome registration modifier 'xpcnativewrappers=n...
Status: VERIFIED FIXED
: polish
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla12
Assigned To: :aceman
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-10 09:35 PST by :aceman
Modified: 2012-02-23 08:16 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.01 KB, patch)
2011-12-10 10:13 PST, :aceman
benjamin: review+
Details | Diff | Splinter Review

Description :aceman 2011-12-10 09:35:37 PST
The severity of the message (warning) is already shown by the icon. Also, when copying this message into clipboard, the text representation gets another "Warning: " prefix before the text. The pasted result is then:

Warning: Warning: Ignoring obsolete chrome registration modifier 'xpcnativewrappers=no'.
Source File: jar:file:///.../.thunderbird/nightly.default/extensions/inspector@mozilla.org.xpi!/chrome.manifest
Line: 17
Comment 1 :aceman 2011-12-10 10:13:08 PST
Created attachment 580658 [details] [diff] [review]
patch
Comment 2 Daniel Holbert [:dholbert] 2012-01-11 15:47:18 PST
Thanks for the patch! Landed:
https://hg.mozilla.org/mozilla-central/rev/8ffdb4c7404a

Also -- in the future, it'd be awesome if you could set up hg to tag you as the author in your patches (and also a commit message, ideally), as described here:
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f

Thanks again!
Comment 3 :aceman 2012-01-11 23:43:54 PST
Yes, I do that, but this patch was created before I started doing it.
Comment 4 Daniel Holbert [:dholbert] 2012-01-12 00:05:35 PST
Ah, great then. :)

Note You need to log in before you can comment on or make changes to this bug.