Closed Bug 709493 Opened 8 years ago Closed 8 years ago

Return JSObject* from nsIScriptTimeoutHandler::GetScriptObject()

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: Ms2ger, Assigned: jhk)

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++][qa-])

Attachments

(1 file, 1 obsolete file)

update iid for nsIScriptTimeoutHandler
3.46 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
Then the cast in nsGlobalWindow.cpp can be removed.
Patch_1
Attachment #581233 - Flags: review?(Ms2ger)
Comment on attachment 581233 [details] [diff] [review]
Return JSObject* from GetScriptObject.

You'll need to update the iid for nsIScriptTimeoutHandler, for example with one generated from <http://mozilla.pettay.fi/cgi-bin/mozuuid.pl>.

Looks good otherwise. Boris, can you review?
Attachment #581233 - Flags: review?(bzbarsky)
Attachment #581233 - Flags: review?(Ms2ger)
Attachment #581233 - Flags: feedback+
Return JSObject* from GetScriptObject.
modified iid for nsIScriptTimeoutHandler.
Attachment #581233 - Attachment is obsolete: true
Attachment #581233 - Flags: review?(bzbarsky)
Attachment #581338 - Flags: review?
Attachment #581338 - Flags: review? → review?(bzbarsky)
Comment on attachment 581338 [details] [diff] [review]
update iid for nsIScriptTimeoutHandler

r=me
Attachment #581338 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a46f9224f2c6

Thanks a lot, Jignesh!
Assignee: nobody → jigneshhk1992
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++] → [good first bug][mentor=Ms2ger][lang=c++][qa-]
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/a46f9224f2c6

Thanks! :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.