Return JSObject* from nsIScriptTimeoutHandler::GetScriptObject()

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: jhk)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++][qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Then the cast in nsGlobalWindow.cpp can be removed.
(Assignee)

Comment 1

6 years ago
Created attachment 581233 [details] [diff] [review]
Return JSObject* from GetScriptObject.

Patch_1
Attachment #581233 - Flags: review?(Ms2ger)
(Reporter)

Comment 2

6 years ago
Comment on attachment 581233 [details] [diff] [review]
Return JSObject* from GetScriptObject.

You'll need to update the iid for nsIScriptTimeoutHandler, for example with one generated from <http://mozilla.pettay.fi/cgi-bin/mozuuid.pl>.

Looks good otherwise. Boris, can you review?
Attachment #581233 - Flags: review?(bzbarsky)
Attachment #581233 - Flags: review?(Ms2ger)
Attachment #581233 - Flags: feedback+
(Assignee)

Comment 3

6 years ago
Created attachment 581338 [details] [diff] [review]
update iid for nsIScriptTimeoutHandler

Return JSObject* from GetScriptObject.
modified iid for nsIScriptTimeoutHandler.
Attachment #581233 - Attachment is obsolete: true
Attachment #581233 - Flags: review?(bzbarsky)
Attachment #581338 - Flags: review?
(Reporter)

Updated

6 years ago
Attachment #581338 - Flags: review? → review?(bzbarsky)

Comment 4

6 years ago
Comment on attachment 581338 [details] [diff] [review]
update iid for nsIScriptTimeoutHandler

r=me
Attachment #581338 - Flags: review?(bzbarsky) → review+

Updated

6 years ago
Keywords: checkin-needed
(Reporter)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a46f9224f2c6

Thanks a lot, Jignesh!
Assignee: nobody → jigneshhk1992
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=Ms2ger][lang=c++] → [good first bug][mentor=Ms2ger][lang=c++][qa-]
Target Milestone: --- → mozilla11

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/a46f9224f2c6

Thanks! :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.