Last Comment Bug 709493 - Return JSObject* from nsIScriptTimeoutHandler::GetScriptObject()
: Return JSObject* from nsIScriptTimeoutHandler::GetScriptObject()
Status: RESOLVED FIXED
[good first bug][mentor=Ms2ger][lang=...
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Jignesh Kakadiya [:jhk]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-10 11:40 PST by :Ms2ger
Modified: 2011-12-16 06:07 PST (History)
2 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Return JSObject* from GetScriptObject. (2.84 KB, patch)
2011-12-13 05:17 PST, Jignesh Kakadiya [:jhk]
Ms2ger: feedback+
Details | Diff | Review
update iid for nsIScriptTimeoutHandler (3.46 KB, patch)
2011-12-13 11:13 PST, Jignesh Kakadiya [:jhk]
bzbarsky: review+
Details | Diff | Review

Description :Ms2ger 2011-12-10 11:40:52 PST
Then the cast in nsGlobalWindow.cpp can be removed.
Comment 1 Jignesh Kakadiya [:jhk] 2011-12-13 05:17:02 PST
Created attachment 581233 [details] [diff] [review]
Return JSObject* from GetScriptObject.

Patch_1
Comment 2 :Ms2ger 2011-12-13 10:01:31 PST
Comment on attachment 581233 [details] [diff] [review]
Return JSObject* from GetScriptObject.

You'll need to update the iid for nsIScriptTimeoutHandler, for example with one generated from <http://mozilla.pettay.fi/cgi-bin/mozuuid.pl>.

Looks good otherwise. Boris, can you review?
Comment 3 Jignesh Kakadiya [:jhk] 2011-12-13 11:13:51 PST
Created attachment 581338 [details] [diff] [review]
update iid for nsIScriptTimeoutHandler

Return JSObject* from GetScriptObject.
modified iid for nsIScriptTimeoutHandler.
Comment 4 Boris Zbarsky [:bz] 2011-12-15 11:50:10 PST
Comment on attachment 581338 [details] [diff] [review]
update iid for nsIScriptTimeoutHandler

r=me
Comment 5 :Ms2ger 2011-12-15 12:05:58 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/a46f9224f2c6

Thanks a lot, Jignesh!
Comment 6 Ed Morley [:emorley] 2011-12-16 06:07:53 PST
https://hg.mozilla.org/mozilla-central/rev/a46f9224f2c6

Thanks! :-)

Note You need to log in before you can comment on or make changes to this bug.