70955 - javascript strict warnings in walletOverlay.js

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://wallet/content/walletOverlay.js line 269: reference to undefined
property window._content.document.forms

Comment 1

[Stephen P. Morse]

This works for me.  Without any more details about how to reproduce this, I have 
to close this out as WFM.  If you are still seeing this and can give a set of 
steps for demonstrating it, then please reopen.

Here is what I did:

1. Added dump statements preceding and following the indicated line in 
walletOverlay.js and rebuilt

2. Go to any url.  I tried about:blank and also tried the sample1 page from 
tasks->privacy->form-manager->demonstration

3. Click the right mouse button to bring up the context menu

At this time I see the output from my two dump statements.  But I do not see any 
javascript warning message.

Comment 2

[Henrik Gemal]

In build 20010316 I'm getting:

Try to capture some form data, and then on the same page rightclick on a input 
field.

JavaScript strict warning:
chrome://wallet/content/walletOverlay.js line 171: reference to undefined proper
ty elementsArray[element].type

Comment 3

[Stephen P. Morse]

I'm still not able to reproduce this.  Can you be more specific and indicate 
which form you are working with, which field you fill in and capture, then which 
field you right-click on.

Also note that the warning message you are now citing is different from the 
warning message you cited when you originally filed this bug report.

Comment 4

[Stephen P. Morse]

Still not able to reproduce.  Since reporter hasn't responded to my request for 
additional information, I'm closing this out.  If there is still a problem, 
please reopen and give specific details.

Comment 5

[Terri Preston]

Works for me too, marking verified

Comment 6

[Henrik Gemal]

Just seen:
JavaScript strict warning:
chrome://wallet/content/walletOverlay.js line 269: reference to undefined 
property window._content.document.forms

in todays build. Happened after going to
ftp://ftp.asuscom.de/pub/ASUSCOM/BIOS/Slot_I/INTEL_Chipset/i440BX/P3B-F/
and right-clicking on the page.

The ftp site showhow for some other reason didn't list any files.

Comment 7

[Stephen P. Morse]

Unable to reproduce.  I am, however, seeing the following error messages when I 
follow the latest instructions (note the middle message is bug 77022):

JavaScript error:
chrome://communicator/content/nsContextMenu.js line 277:
root.getAttribute is not a function

JavaScript error:
chrome://cookie/content/cookieContextOverlay.xul line 94:
contextMenu has no properties

JavaScript error:
line 0: contextMenu has no properties

Comment 8

[Stephen P. Morse]

Closing again as works-for-me.  Will make additional comments in bug 77022.

Comment 9

[Henrik Gemal]

Ok, once again:

Make sure you have user_pref("javascript.options.strict", true); in your 
prefs.js

then go to:
1) ftp://ftp.dk.net/
2) open the directory "mirrors"
3) rightclick on the "ftp.cs.hut.fi" directory

js warning is shown in the console.

Comment 10

[Viswanath Ramachandran]

this is not a mozilla0.9 stopper. we would like some help fixing this - hence 
moving to Future and helpwanted. 

Comment 11

[Stephen P. Morse]

Doesn't make sense to hide this under the rug (marking "future") since it's so 
easy to fix and it could be affecting bug 77073 as well.

Problem is occuring because the display for the ftp site is a xul document 
instead of an html document and so it doesn't have any forms.  Attaching 
patch that expicitly tests for that.

Comment 12

[Stephen P. Morse]

Attachment: explicit test for html document as opposed to xul document

Comment 13

[Stephen P. Morse]

law, please review attached patch.  alecf, please super-review.  Thanks.

Comment 14

[Alec Flett]

sr=alecf

Comment 15

[Bill Law]

r=law

Comment 16

[Asa Dotzler [:asa]]

Are you still shooting for 0.9 on this? If so please email [e-mail]
with a status on you progress. If not please retarget against a later Milestone.
Thanks.

Comment 17

[Viswanath Ramachandran]

steve, please move this to mozilla0.9.1 unless critical for mozilla0.9. thanks, 
Vishy. 

Comment 18

[Stephen P. Morse]

Fix checked in.

Comment 19

[Terri Preston]

Verified fix checked into lxr.mozilla.org

Comment 20

[Henrik Gemal]

Morse... just seen this...:

Warning: assignment to undeclared variable state
Source File: chrome://wallet/content/walletOverlay.js
Line: 253

Comment 21

[Stephen P. Morse]

This bug report is for undefined property window._content.document.forms and 
that has been fixed.  This new bug is for variable state and so is a separate 
bug report.  Please open a new report on it.  Also include steps for 
reproducing, otherwise there isn't much I can do with it.

Comment 22

[Henrik Gemal]

ok... he, he. I have to remember which netscape.com developer who like to have 
the bug reopen and which (like you) who like to have a new bug...:)