Closed Bug 709567 Opened 14 years ago Closed 14 years ago

B2G SMS: DOM to RIL plumbing in ril_worker.js

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: philikon, Assigned: philikon)

References

Details

Attachments

(2 files)

Part 1 (v1): Plumbing for incoming SMS
4.89 KB, patch
qdot
: review+
Details | Diff | Splinter Review
Part 2 (v1): Plumbing for outgoing SMS
7.48 KB, patch
qdot
: review+
Details | Diff | Splinter Review
Pretty straight forward stuff, just need to do the extra PDU parsing/formatting step (bug 709566)
Version: unspecified → Trunk
Component: DOM → DOM: Device Interfaces
QA Contact: general → device-interfaces
This is the plumbing for incoming SMS. Pipes messages through the PDU parser and sends events to the main thread.
Assignee: nobody → philipp
Attachment #582624 - Flags: review?(kyle)
Comment on attachment 582624 [details] [diff] [review] Part 1 (v1): Plumbing for incoming SMS Review of attachment 582624 [details] [diff] [review]: ----------------------------------------------------------------- Fairly straight forward changes, looks good.
Attachment #582624 - Flags: review?(kyle) → review+
For outgoing SMS, the whole encoding issue is a bit tricky. Since the mainthread is going to have to calculate how many text messages a certain payload will take (which will involve choosing an appropriate encoding, etc.), we might as well pass that information (appropriate encoding, byte length in encoded form) down from the mainthread. We don't do this yet, for now it's hard coded. But this should explain the somewhat awkward structure. If we find a better way some time donw the road, we can always refactor, too.
Attachment #583954 - Flags: review?(kyle)
Comment on attachment 583954 [details] [diff] [review] Part 2 (v1): Plumbing for outgoing SMS Review of attachment 583954 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. r=me.
Attachment #583954 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/283bd1cc9f13 https://hg.mozilla.org/mozilla-central/rev/6cb5f489a82c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: