709619 - Resizing and restoring elements' size when default width/height is not represented in px

Status: NEW

(Core :: XUL, defect)

Description

[spammed.user]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Build ID: 20111206234556

Steps to reproduce:

Resize and double-click the resizer of an element with a "width" or "height" attribute represented in percents.


Actual results:

The current width/height is set to default. Resizing the element again and double-clicking the resizer will set width and height to these values.


Expected results:

width/height should have been restored to it's original value, represented in %.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yeah, looks like a bug in nsResizerFrame::ResizeContent.  I assumes that he resizeInfo contains either a number followed by "px" or just a number, and appends "px" if it can't find "px" at the end already.  Which is just wrong for percentage sizes.  Why is it doing that?

Comment 2

[Boris Zbarsky [:bzbarsky]]

ccing the author of this code too.  ;)

Comment 3

[Boris Zbarsky [:bzbarsky]]

> I assumes that he resizeInfo 

"It assumes that the resizeInfo".  I need a new keyboard, clearly!

Comment 4

[[e-mail]]

> resizeInfo contains either a number followed by "px" or just a number, and
> appends "px" if it can't find "px" at the end already.
[The string code that tries to find "px" is dire anyway...]

> Which is just wrong for percentage sizes.
And indeed for all other non-px units!