Fix GC heap memory reporters

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 580826 [details] [diff] [review]
patch

I found that the sum of all the GC heap memory reporters was about 5% 
greater than the total size of the GC heap.  Turns out there there two culprits: 

- The computation of gcHeapChunkDirtyUnused didn't account for 
  gcHeapShapesBase.

- "type-inference/object-main" was incorrectly marked as having 
  JS_GC_HEAP_KIND.

So "explicit", "gc-heap-chunk-dirty-unused", and "heap-unclassified" were all inflated slightly.

I added an assertion to make sure that this mismatch will be detected if it
occurs again in the future.  (This assertion would also have caught the 
incorrect kind markings in bug 704391.)

I also renamed countDecommittedArenas() because it was confusing the hell 
out of me.
Attachment #580826 - Flags: review?(bhackett1024)
(Assignee)

Updated

6 years ago
Whiteboard: [MemShrink]
Attachment #580826 - Flags: review?(bhackett1024) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [MemShrink] → [MemShrink:P2]
(Assignee)

Comment 1

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b94d12f3e2d
https://hg.mozilla.org/mozilla-central/rev/2b94d12f3e2d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.