Last Comment Bug 709653 - Fix GC heap memory reporters
: Fix GC heap memory reporters
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla11
Assigned To: Nicholas Nethercote [:njn]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-12-11 21:15 PST by Nicholas Nethercote [:njn]
Modified: 2011-12-19 05:42 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (19.20 KB, patch)
2011-12-11 21:15 PST, Nicholas Nethercote [:njn]
bhackett1024: review+
Details | Diff | Splinter Review

Description User image Nicholas Nethercote [:njn] 2011-12-11 21:15:47 PST
Created attachment 580826 [details] [diff] [review]

I found that the sum of all the GC heap memory reporters was about 5% 
greater than the total size of the GC heap.  Turns out there there two culprits: 

- The computation of gcHeapChunkDirtyUnused didn't account for 

- "type-inference/object-main" was incorrectly marked as having 

So "explicit", "gc-heap-chunk-dirty-unused", and "heap-unclassified" were all inflated slightly.

I added an assertion to make sure that this mismatch will be detected if it
occurs again in the future.  (This assertion would also have caught the 
incorrect kind markings in bug 704391.)

I also renamed countDecommittedArenas() because it was confusing the hell 
out of me.
Comment 1 User image Nicholas Nethercote [:njn] 2011-12-18 15:41:24 PST
Comment 2 User image Marco Bonardo [::mak] 2011-12-19 05:42:40 PST

Note You need to log in before you can comment on or make changes to this bug.