709713 - Cloudflare.com says Firefox 10+ needs an upgrade

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: English Other, defect)

Description

[Matthew N. [:MattN]]

"WARNING    Your current browser may not display CloudFlare correctly. We highly recommend that you upgrade your browser before continuing!"

In the code below from the minified cloudflare.js, they are passing "1" as the length argument to substr so version 10+ is detected as 1.

<snip>
case c.cf.clientType.gecko:
  a = parseInt(c.browser.version.substr(0,1));
  var b = parseInt(c.browser.version.substr(2,1)), d;
  try{
    d=parseInt(c.browser.version.substr(4,1))
  } catch(e) {
    d=0
  }
return a > 0 ? b > 7 ? b > 8 && d > 0 ? c.cf.clientStatus.standard : c.cf.clientStatus.deprecated : a > 1 ? 
c.cf.clientStatus.standard : c.cf.clientStatus.obsolete : c.cf.clientStatus.obsolete;
</snip>

No warning appears when I spoof Firefox 7.0.1

I'm going to reporting the issue at http://support.cloudflare.com/cgi/discussion/new

Comment 1

[Matthew N. [:MattN]]

I received a reply:
"Thanks! I sent it to our UI folks to take a look at."

Comment 2

[j.j.]

Moving to "Tech Evangelism"

Comment 3

[Matthew N. [:MattN]]

I received an email from Jason at CloudFlare that this has been fixed and pushed to the production website:
"I've updated the CloudFlare website (www.cloudflare.com) to remove assumptions about version number length."

I can confirm that the warning bar is no longer displayed.

Thanks to CloudFlare.com for the extremely quick turnaround!