[XUL Syntax] Add -moz-window-icon property to CSS

RESOLVED INCOMPLETE

Status

()

defect
RESOLVED INCOMPLETE
19 years ago
Last year

People

(Reporter: hyatt, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [XUL1.0])

Attachments

(1 attachment)

Reporter

Description

19 years ago
Bill needs this for the custom window icon skinnability work.
Reporter

Updated

19 years ago
Status: NEW → ASSIGNED
Depends on: 70753
Whiteboard: [XUL1.0]
Target Milestone: --- → mozilla0.9
Reporter

Updated

19 years ago
Blocks: 57576
Reporter

Updated

19 years ago
No longer depends on: 70753
Reporter

Updated

19 years ago
Blocks: 70753
Reporter

Updated

19 years ago
OS: Mac System 8.5 → All
Reporter

Updated

19 years ago
Target Milestone: mozilla0.9 → mozilla0.9.1
nominating for mozilla0.9.1 and nsbeta1. 
Reporter

Updated

18 years ago
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Reporter

Comment 2

18 years ago
--> future.  
Target Milestone: mozilla0.9.2 → Future

Comment 3

18 years ago
stealing
Assignee: hyatt → blakeross
Status: ASSIGNED → NEW
Hardware: Macintosh → All
Reporter

Comment 4

18 years ago
This bug cannot be worked on until I land my style branch.  You should not 
target it any earlier than 0.9.2.  IMO there are many better things from my 
list that you could be helping out with. :)

Icons are already differentiable in Bill Law's code without this, so IMO this 
bug is very low priority.
Status: NEW → ASSIGNED

Comment 5

18 years ago
Ah, I see.  I thought this was needed for per-window icons, so it sucked to see 
it futured, since it seems like it should be easy anyways.  So since this is 
just for skinability, I'll push it off, or you can take it back if you'd like...
Target Milestone: Future → mozilla1.0

Comment 6

18 years ago
Okay, this isn't really needed right now, so back to hyatt.
Assignee: blake → hyatt
Status: ASSIGNED → NEW
Reporter

Updated

18 years ago
No longer blocks: 57576, 70753

Comment 7

18 years ago
Any progress on this? 
I have an XUL app with multiple windows. Assigning a different icon to each 
window would make window selection from the task manager much easier. 
What is Bill Law's code which is claimed to solve this problem? Is it available 
from js?

Comment 8

18 years ago
ChatZilla would like to be able to do this too.

Comment 9

18 years ago
This bug is about not being able to "skin" the window icons.  You can have
different icons for each window via a fall-back scheme that is described in bug
57576 (see my comment dated 2001-03-27 18:09).  Netscape6.x uses this technique.

Comment 10

18 years ago
Who said anything about skinning?

I'm not concerned about skinning, just the ability to specify a window icon in a
cross platform way (what are linux, mac, os/2, etc, going to do with .ico
files?), and store that icon in my application's .jar file.

Comment 11

18 years ago
Well, one would expect the window icon might change with the classic skin vs. the 
modern skin in line with other ui elements. Some might argue its better if it 
doesn't for usability purposes, but that can easily be achieved for Netscape (or 
other vendor shipped) themes if those vendors want to set it up what way by 
simply using the same icon in every skin.

It is quite platform specific however. On Mac OS the icon in the title bar is per 
*document* not per window type, so we might use the bookmark icon for URLs in 
Navigator or indeed perhaps even the favicon.ico one day... Messenger might need 
an icon to represent a mail message being composed. This icon might be 
implemented by the same property law is defining for the taskbar on windows, or 
it might be a compeletely seperate mechanism (my gut feeling).
Reporter

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla1.0.1

Comment 13

18 years ago
The attached patch only adds "-moz-window-icon" into the style system.  For
actually using the property, there is bug 76211 for GTK which I'm currently
working on.  I will probably do Windows as well.  Someone else will have to do
any other platforms.

Comment 14

17 years ago
I haven't had opportunity to work on the gtk icon bug, but I have kept this
style system patch up to date in my tree so if it's worthwhile I could attach an
updated version.

Comment 15

17 years ago
I've been keeping this up to date in my tree, which was quite painful with all
the style changes...  Is anyone actually interested in this?
I talked to dbaron at some point this summer about this bug and IIRC his general
opinion was that we would consider this if someone contributed a patch that made
this work on all (most?) platforms.

Comment 17

17 years ago
There's 2 parts to this.  This bug is just for implementing the style and is
cross-platform.  The actual code for displaying the icon is platform dependant
and the question there is do we want to be able to use any picture file as the
icon or can that be platform specific.  (e.g. .ico on windows, .xpm on unix)
What good is this patch though if it does nothing?  The only thing it will do is
not throw a CSS parser error if someone does '-moz-window-icon: url(foo)' but it
won't set the actual icon.  IMO, that is actually worse since people will expect
setting the property to have some effect if there is no error.  I really don't
see the point in only doing the style system changes.
That said, I think that this does work on most platforms now.  There is a bunch
of code that I #if 0'd out in nsXULWindow::LoadIconFromXUL() a while back since
it didin't do anything.  That could be un-#if 0'd and included with the changes...

Comment 20

17 years ago
nsImageMac has code that can turn any nsIImage (ie, png, jpeg, gif etc) that 
Mozilla can understand into a native Mac icon, so it probably is implementable on 
that platform.

Updated

11 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
Is this still needed/wanted? There's a bunch of code in nsXULWindow that's #if'd 0 waiting on this bug...
Assignee: hyatt → nobody
Status: ASSIGNED → NEW
Target Milestone: mozilla1.0.1 → ---
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.