Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Move tri-licensed Android library parts under mozutils

RESOLVED FIXED in Firefox 11

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla12
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 fixed)

Details

(Whiteboard: [inbound])

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

6 years ago
There is no real reason to keep our Gecko android c++ code under other-licenses/android when the code is tri-licensed.
(Assignee)

Comment 1

6 years ago
Created attachment 580903 [details] [diff] [review]
Move tri-licensed Android library parts under mozutils/
Attachment #580903 - Flags: review?(blassey.bugs)
(Assignee)

Updated

6 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Updated

6 years ago
Blocks: 683127
(Assignee)

Comment 2

6 years ago
Created attachment 580982 [details] [diff] [review]
Move tri-licensed Android library parts under mozutils/

Refreshed
(Assignee)

Updated

6 years ago
Attachment #580903 - Attachment is obsolete: true
Attachment #580903 - Flags: review?(blassey.bugs)
(Assignee)

Comment 3

6 years ago
Created attachment 580991 [details] [diff] [review]
Move tri-licensed Android library parts under mozutils/

Edited the wrong patch on the wrong bug. Restoring the previous one.
Attachment #580991 - Flags: review?(blassey.bugs)
(Assignee)

Updated

6 years ago
Attachment #580982 - Attachment is obsolete: true
Attachment #580991 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 583736 [details] [diff] [review]
Move tri-licensed Android library parts under mozglue/.

Refreshed patch against bug 701371, which instead of just moving mozutils, also now renames it.
(Assignee)

Updated

6 years ago
Attachment #580991 - Attachment is obsolete: true
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ac6f34b44ff
Whiteboard: [inbound]
(Assignee)

Comment 6

6 years ago
Backed out because of random and unexplainable android bustages.
https://hg.mozilla.org/integration/mozilla-inbound/rev/db6e5b2bf92d
Whiteboard: [inbound]
(Assignee)

Comment 7

6 years ago
The Android bustages were due to the missing ANDROID_ARM_LINKER definition in mozglue/android/Makefile.in (it's the only DEFINE from other-licenses/android/Makefile.in that is used in APKOpen.cpp). The result is that we were missing the cache flushes from bug 690856 and were hitting it again.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c899dde43144
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/c899dde43144
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
(Assignee)

Comment 9

6 years ago
Created attachment 591485 [details] [diff] [review]
Move tri-licensed Android library parts under mozglue/ - for aurora

[Approval Request Comment]
This is a dependency for bug 683127 and bug 713228. It only moves code around.
Attachment #591485 - Flags: review+
Attachment #591485 - Flags: approval-mozilla-aurora?
Attachment #591485 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 10

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/3352a89d2dde
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.