Closed
Bug 709888
Opened 14 years ago
Closed 14 years ago
Remove UA switcher
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox11 fixed, firefox12 verified, fennec11+)
VERIFIED
FIXED
Firefox 12
People
(Reporter: lmandel, Assigned: bnicholson)
Details
(Whiteboard: [mtd])
Attachments
(1 file, 1 obsolete file)
21.12 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The Request Desktop Site option is not applicable for many pages:
- sites that only have desktop content
- sites that do not recognize Firefox mobile and return the desktop content
- mobiles sites that I explicitly navigate to (for ex. open m.imdb.com in your browser) (because Firefox gets the desktop sites by default)
- about: pages
While I like the idea of being able to request the desktop vs mobile version of a site and would find this option useful if it worked reliably, I do not find this option useful today. At this point I think the option just adds a source of confusion to the browser (and affects the browser polish as the option appears to do nothing on many sites). I would like to suggest that this option should be removed from the menu until such time that it is generally applicable when browsing in Firefox mobile.
Comment 1•14 years ago
|
||
bug 706264 is about redirects to mobiles sites breaking 'request desktop site'. From my brief look into Android browsers it seems that most implement this as a global option or a set of sites to use a a specific UA with.
Comment 2•14 years ago
|
||
I agree with Lawrence. It fails often enough that it's more frustrating to have it than to not. This feature really ought to be removed because it's just not reliable enough.
Comment 3•14 years ago
|
||
I think we should hide/remove this feature.
Assignee: nobody → kbrosnan
Priority: -- → P1
Comment 4•14 years ago
|
||
Assignee: kbrosnan → doug.turner
Updated•14 years ago
|
Attachment #586573 -
Flags: review?(mbrubeck)
Comment 5•14 years ago
|
||
Comment on attachment 586573 [details] [diff] [review]
patch v.1
We do want to remove the feature. I talked to Brian about removing it all. Even the part in browser.js
Attachment #586573 -
Flags: review?(mbrubeck) → review-
Updated•14 years ago
|
Assignee: doug.turner → bnicholson
Updated•14 years ago
|
tracking-fennec: --- → 11+
Assignee | ||
Updated•14 years ago
|
Summary: Request Desktop Site option not applicable for many pages → Remove UA switcher
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #586573 -
Attachment is obsolete: true
Attachment #587090 -
Flags: review?(mark.finkle)
Updated•14 years ago
|
Attachment #587090 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 7•14 years ago
|
||
Landed on mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c04fb55118f8
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment 9•14 years ago
|
||
Comment on attachment 587090 [details] [diff] [review]
patch v2
[Approval Request Comment]
Removal of the feature on Aurora
Attachment #587090 -
Flags: approval-mozilla-aurora?
Comment 10•14 years ago
|
||
Verified on Nightly (12.0a1)
Samsung Nexus S (Android 4.0.3)
20120113052739
http://hg.mozilla.org/mozilla-central/rev/790cd9bba7f5
Status: RESOLVED → VERIFIED
status-firefox11:
--- → verified
Updated•14 years ago
|
status-firefox12:
--- → verified
Comment 11•14 years ago
|
||
Comment on attachment 587090 [details] [diff] [review]
patch v2
[Triage Comment]
Mobile only - approved for Aurora.
Attachment #587090 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•14 years ago
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•