Closed Bug 710112 Opened 9 years ago Closed 9 years ago

cleanup xpcom/io for windows (reduce LoadLibrary/PR_LoadLibrary)

Categories

(Core :: XPCOM, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

shell32.dll is already linked, so shell32.dll is loaded with xul.dll.  So we should use GetModuleHandleW instread.  This doesn't need to call FreeLibrary.

Also, nsLocalFileWin is for Windows only, it is no reason to use PR_LoadLibrary.
Attached patch fixSplinter Review
Attachment #587934 - Flags: review?(jmathies)
Attachment #587934 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/3f378d354444
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.