cleanup xpcom/io for windows (reduce LoadLibrary/PR_LoadLibrary)

RESOLVED FIXED in mozilla12

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla12
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
shell32.dll is already linked, so shell32.dll is loaded with xul.dll.  So we should use GetModuleHandleW instread.  This doesn't need to call FreeLibrary.

Also, nsLocalFileWin is for Windows only, it is no reason to use PR_LoadLibrary.
(Assignee)

Comment 1

6 years ago
Created attachment 587934 [details] [diff] [review]
fix
(Assignee)

Updated

6 years ago
Attachment #587934 - Flags: review?(jmathies)

Updated

6 years ago
Attachment #587934 - Flags: review?(jmathies) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f378d354444
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/3f378d354444
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.