Last Comment Bug 710112 - cleanup xpcom/io for windows (reduce LoadLibrary/PR_LoadLibrary)
: cleanup xpcom/io for windows (reduce LoadLibrary/PR_LoadLibrary)
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86 Windows Vista
-- normal (vote)
: mozilla12
Assigned To: Makoto Kato [:m_kato]
: Nathan Froyd [:froydnj]
Depends on:
  Show dependency treegraph
Reported: 2011-12-12 19:23 PST by Makoto Kato [:m_kato]
Modified: 2012-01-16 19:36 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (6.09 KB, patch)
2012-01-11 20:24 PST, Makoto Kato [:m_kato]
jmathies: review+
Details | Diff | Splinter Review

Description User image Makoto Kato [:m_kato] 2011-12-12 19:23:22 PST
shell32.dll is already linked, so shell32.dll is loaded with xul.dll.  So we should use GetModuleHandleW instread.  This doesn't need to call FreeLibrary.

Also, nsLocalFileWin is for Windows only, it is no reason to use PR_LoadLibrary.
Comment 1 User image Makoto Kato [:m_kato] 2012-01-11 20:24:52 PST
Created attachment 587934 [details] [diff] [review]
Comment 3 User image Justin Wood (:Callek) [away until Feb 27] 2012-01-16 19:36:37 PST

Note You need to log in before you can comment on or make changes to this bug.