Remove MOZ_REQUIRE_CURRENT_SDK from nsPrintDialogUtil.cpp

RESOLVED FIXED in mozilla11

Status

Core Graveyard
Embedding: GRE Core
RESOLVED FIXED
6 years ago
11 months ago

People

(Reporter: m_kato, Assigned: emorley)

Tracking

Trunk
mozilla11
All
Windows Vista
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
MOZ_REQUIRE_CURRENT_SDK is unused.  We should remove MOZ_REQUIRE_CURRENT_SDK related code in embedding/components/printingui/src/win/nsPrintDialogUtil.cpp.

MOZ_REQUIRE_CURRENT_SDK is used on Firefox 1?, but Gecko 1.8 and later, this isn't used.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
https://tbpl.mozilla.org/?tree=Try&rev=7ce27fb4cc9d
Created attachment 581582 [details] [diff] [review]
Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=7ce27fb4cc9d
Attachment #581582 - Flags: review?(benjamin)
Attachment #581582 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e0f286f79be
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/9e0f286f79be
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Was this change in the right direction?  It looks like we now (compile-time) unconditionally use the *old* print dialog rather than the *new* one.
MOZ_REQUIRE_CURRENT_SDK wasn't defined anywhere, so the removed code shouldn't have been being compiled anyway, unless I'm missing something?

http://mxr.mozilla.org/mozilla-central/search?string=MOZ_REQUIRE_CURRENT_SDK

I'm afk until Monday, but if this was indeed the wrong way, please do back me out! :-)
Sorry, I should have been clearer.  I'm aware it wasn't being compiled.  I'm asking whether it *should* have been compiled (possibly under some other conditional - looking at widget/src/windows, we seem to be using '#if MOZ_WINSDK_TARGETVER >= something' for similar scenarios).
(Reporter)

Comment 8

6 years ago
(In reply to Zack Weinberg (:zwol) from comment #7)
> Sorry, I should have been clearer.  I'm aware it wasn't being compiled.  I'm
> asking whether it *should* have been compiled (possibly under some other
> conditional - looking at widget/src/windows, we seem to be using '#if
> MOZ_WINSDK_TARGETVER >= something' for similar scenarios).

Actually, this code is broken and cannot compile due to various compile error now.

We should re-design print dialog if UX team is needed.
(In reply to Makoto Kato from comment #8)
> 
> Actually, this code is broken and cannot compile due to various compile
> error now.
> 
> We should re-design print dialog if UX team is needed.

Thanks for the update.  In that case, I am happy with what was done here; future adjustments can happen in bug 693230 and/or bug 650957.
Phew! Had me worried there for a sec! Second pair of eyes always appreciated though, so thanks for checking :-)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.