Last Comment Bug 710152 - GCLI javascript completion should stop providing completions with 'complex' JS input
: GCLI javascript completion should stop providing completions with 'complex' J...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 12
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on:
Blocks: GCLI-SHIP
  Show dependency treegraph
 
Reported: 2011-12-13 02:14 PST by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-01-10 14:50 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
upload 1 (6.92 KB, patch)
2011-12-13 10:32 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dcamp: review+
Details | Diff | Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-13 02:14:18 PST
Currently the completion proposal for:

> console.log(

is: console.log(console

Which, while being a possible input, is clearly quite unlikely. In fact the likely inputs here are hard to predict.

Also the completion proposal for:

> [1, 2, 3].forEach(function(i) {

Depends on the value of the second parameter to the forEach function. Something that we currently ignore, and will be hard to get right given that it hasn't been typed yet.

So we should give up providing completions when the input contains something other than alphanumerics and dots.
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-12-13 10:32:35 PST
Created attachment 581320 [details] [diff] [review]
upload 1

a.k.a https://github.com/campd/gcli/pull/12
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-09 07:50:03 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ea2996a1f3c
Comment 3 Tim Taubert [:ttaubert] 2012-01-10 14:50:03 PST
https://hg.mozilla.org/mozilla-central/rev/62cca592625d

Note You need to log in before you can comment on or make changes to this bug.