GCLI javascript completion should stop providing completions with 'complex' JS input

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools: Console
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently the completion proposal for:

> console.log(

is: console.log(console

Which, while being a possible input, is clearly quite unlikely. In fact the likely inputs here are hard to predict.

Also the completion proposal for:

> [1, 2, 3].forEach(function(i) {

Depends on the value of the second parameter to the forEach function. Something that we currently ignore, and will be hard to get right given that it hasn't been typed yet.

So we should give up providing completions when the input contains something other than alphanumerics and dots.
Component: Developer Tools → Developer Tools: Console
QA Contact: developer.tools → developer.tools.console
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Created attachment 581320 [details] [diff] [review]
upload 1

a.k.a https://github.com/campd/gcli/pull/12
Attachment #581320 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #581320 - Flags: review?(dcamp) → review+
https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ea2996a1f3c
Whiteboard: [landed-in-fxteam]
https://hg.mozilla.org/mozilla-central/rev/62cca592625d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [landed-in-fxteam]
Target Milestone: --- → Firefox 12
You need to log in before you can comment on or make changes to this bug.