The default bug view has changed. See this FAQ.

create a typedef for nsCharSeparatedTokenizer<nsContentUtils::IsHTMLWhitespace> and convert users in the tree to use the new typedef

RESOLVED FIXED in mozilla12

Status

()

Core
General
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: imelven, Assigned: Santiago Gimeno)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=khuey][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
as part of feedback on bug 341604 khuey suggested creating a "typedef nsCharSeparatedTokenizer<nsContentUtils::IsHTMLWhitespace> HTMLSplitOnSpacesTokenizer (or something)" in nsContentUtils.h and changing the existing users in the tree to use this new typedef

this seems like a pretty great first bug also.
(Reporter)

Updated

5 years ago
Blocks: 341604
(Reporter)

Comment 1

5 years ago
nsCharSeparatedTokenizerTemplate<nsContentUtils::IsHTMLWhitespace> looks to be the actual thing to typedef

Comment 2

5 years ago
Kyle, feel free to take your name off this if you want.
Whiteboard: [mentor=khuey][lang=c++]
(Assignee)

Comment 3

5 years ago
Created attachment 585716 [details] [diff] [review]
Add and use new HTMLSplitOnSpacesTokenizer typedef
Attachment #585716 - Flags: review?(khuey)

Updated

5 years ago
Assignee: nobody → santiago.gimeno
Comment on attachment 585716 [details] [diff] [review]
Add and use new HTMLSplitOnSpacesTokenizer typedef

Review of attachment 585716 [details] [diff] [review]:
-----------------------------------------------------------------

Nice patch.  Thanks!
Attachment #585716 - Flags: review?(khuey) → review+

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/80cc942b8db7
Thanks! :-)

https://hg.mozilla.org/mozilla-central/rev/80cc942b8db7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.