Last Comment Bug 710292 - create a typedef for nsCharSeparatedTokenizer<nsContentUtils::IsHTMLWhitespace> and convert users in the tree to use the new typedef
: create a typedef for nsCharSeparatedTokenizer<nsContentUtils::IsHTMLWhitespac...
Status: RESOLVED FIXED
[mentor=khuey][lang=c++]
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla12
Assigned To: Santiago Gimeno
:
Mentors:
Depends on:
Blocks: framesandbox
  Show dependency treegraph
 
Reported: 2011-12-13 11:02 PST by Ian Melven :imelven
Modified: 2012-01-04 17:29 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add and use new HTMLSplitOnSpacesTokenizer typedef (4.84 KB, patch)
2012-01-04 05:08 PST, Santiago Gimeno
khuey: review+
Details | Diff | Review

Description Ian Melven :imelven 2011-12-13 11:02:48 PST
as part of feedback on bug 341604 khuey suggested creating a "typedef nsCharSeparatedTokenizer<nsContentUtils::IsHTMLWhitespace> HTMLSplitOnSpacesTokenizer (or something)" in nsContentUtils.h and changing the existing users in the tree to use this new typedef

this seems like a pretty great first bug also.
Comment 1 Ian Melven :imelven 2011-12-13 15:39:39 PST
nsCharSeparatedTokenizerTemplate<nsContentUtils::IsHTMLWhitespace> looks to be the actual thing to typedef
Comment 2 Josh Matthews [:jdm] 2011-12-13 19:33:10 PST
Kyle, feel free to take your name off this if you want.
Comment 3 Santiago Gimeno 2012-01-04 05:08:05 PST
Created attachment 585716 [details] [diff] [review]
Add and use new HTMLSplitOnSpacesTokenizer typedef
Comment 4 Kyle Huey [:khuey] (khuey@mozilla.com) 2012-01-04 09:40:27 PST
Comment on attachment 585716 [details] [diff] [review]
Add and use new HTMLSplitOnSpacesTokenizer typedef

Review of attachment 585716 [details] [diff] [review]:
-----------------------------------------------------------------

Nice patch.  Thanks!
Comment 6 Ed Morley [:emorley] 2012-01-04 17:29:09 PST
Thanks! :-)

https://hg.mozilla.org/mozilla-central/rev/80cc942b8db7

Note You need to log in before you can comment on or make changes to this bug.