710302 - going to about: pages does a "feeling lucky" search

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[juan becerra [:juanb]]

Using the latest nightly when I go to about: I get a google search results for "about:" instead of the usual about page.

Steps:
1. Install the latest nightly
2. Enter about: in the location field and enter

Expected: about: page showing me information about the build and so on

Actual: Google search results page 

I haven't looked for a regression.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: bustage fix for various schemes

The was regressed by bug 701374. This patch adds checks for various known schemes. Tested and it fixes the issue.

I could try to just use some test for the colon, but this seems more straight forward.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 581435 [details] [diff] [review]
bustage fix for various schemes

Maintaining a list of valid URI schemes feel too likely to break in unforseen cases.  ("chrome:" and "jar:" are already missing.)  I'd rather treat any string that contains a colon (without a space preceding it) as a URI.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: simpler fix

This version uses the "if a colon exists && before a space" logic

Also fixes the problem

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: even simpler fix

I think this is equivalent, and even simpler.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 581448 [details] [diff] [review]
even simpler fix

Works for me

Comment 6

[Matt Brubeck (:mbrubeck)]

Attachment: patch for checkin

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/mozilla-central/rev/0c46aac6a23f

Comment 8

[Catalin Suciu [:csuciu]]

Verified fixed on the latest fennec native build:
Mozilla /5.0 (Android;Linux armv7l;rv:11.0a1) Gecko/20111214 Firefox/11.0a1 Fennec/11.0a1 
Device: HTC Desire (Android 2.2)