The default bug view has changed. See this FAQ.

about:home - add UI for when there are no thumbnails or no addons

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
5 years ago
8 months ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

({uiwanted})

unspecified
Firefox 13
ARM
Android
uiwanted
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 fixed, fennec11+)

Details

(Whiteboard: [QA?])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
We should show a message when that happens. Ian had design for that I think.
Priority: -- → P2
Assignee: nobody → ibarlow
Keywords: uiwanted
Hardware: All → ARM
tracking-fennec: --- → 11+
Created attachment 588893 [details]
Mockup of start page empty states

If no top sites are found:
"You do not have any top sites.
Tap the Title Bar to start browsing."

If no add-ons are found:
"No available add-ons"
(Assignee)

Comment 2

5 years ago
Working on a patch for this one.
Assignee: ibarlow → lucasr.at.mozilla

Comment 3

5 years ago
This sounds like new strings to me?
(Assignee)

Comment 4

5 years ago
(In reply to Axel Hecht [:Pike] from comment #3)
> This sounds like new strings to me?

Yes.

Updated

5 years ago
Keywords: late-l10n

Comment 5

5 years ago
Brad, Mark, is this still 11 material?
(In reply to Axel Hecht [:Pike] from comment #5)
> Brad, Mark, is this still 11 material?

It's possible. I don't think this is truly a P2 though.
(Assignee)

Comment 7

5 years ago
The thumbnails part has already been done in bug 708414. It should be simple to implement the addons part. Ian, Madhava, do you prefer the whole section to be hidden when there are no recommended addons? Or is it still the case to show a message?
Lucas, after thinking about it a little more I think we should hide add-ons completely if there isn't anything to show. 

Showing an empty state for Top Sites is more useful, as quick access to your stuff is a primary purpose for this start page. Since Add-ons are somewhat lower in importance here, I don't think people will miss anything if we aren't telling them we don't have anything to show them ;)

Comment 9

5 years ago
Confirmed on irc, Ian says we don't need more strings for this bug. Removing late-l10n keyword.
Keywords: late-l10n
(Assignee)

Comment 10

5 years ago
Created attachment 593159 [details] [diff] [review]
Hide recommended addons section from about:home when empty
Attachment #593159 - Flags: review?(mark.finkle)
Attachment #593159 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 11

5 years ago
Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/63f719f6681b
(Assignee)

Comment 12

5 years ago
Comment on attachment 593159 [details] [diff] [review]
Hide recommended addons section from about:home when empty

Non-risky. Fixes broken visual on about:home when there are no addons to recommend.
Attachment #593159 - Flags: approval-mozilla-beta?
Attachment #593159 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/63f719f6681b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Comment on attachment 593159 [details] [diff] [review]
Hide recommended addons section from about:home when empty

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593159 - Flags: approval-mozilla-beta?
Attachment #593159 - Flags: approval-mozilla-beta+
Attachment #593159 - Flags: approval-mozilla-aurora?
Attachment #593159 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/53b837964a4b
status-firefox11: --- → affected
status-firefox12: --- → fixed
status-firefox13: --- → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/5e2e576fa0e0
status-firefox11: affected → fixed

Comment 17

5 years ago
Nightly 13.0a1 (2012-02-07)
Aurora 12.0a2 (2012-02-07)
Beta 11.0 (20120206202409 - http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116)
Device: Samsung Google Nexus S - Android 2.3.6


UI for no thumbnails on start page is correctly displayed(as in attachment from comment 1), but how do you verify no addons. I tried starting Fennec with a clear profile and no internet internet connection, but 2 addons: Cleary and Clear Mobile History are always displayed
Whiteboard: [QA?]
Those are duds. I have no idea if and when they will be hooked up.
You need to log in before you can comment on or make changes to this bug.