710364 - Opening a link in a new tab context menu header is wrong with image links

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

Ex:

<a href="http://www.mozilla.org"><img 
src="http://mozcom-cdn.mozilla.net/img/covehead/firefox/brand-toolkit/download/logo-only.png"></a>

The header (above "Open link in new tab") is the image source where it should be the href for the anchor.

Comment 1

[Aaron Train [:aaronmt]]

What's incomplete about this?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Seems to be working for me

Comment 3

[Adrian Tamas (:AdrianT)]

Attachment: screenshot

I created a simple html page with code from Comment 0 and copied the file to the device. I then opened the file using Nightly 2012-07-01. When opening the context menu for the link the href of the picture is displayed not the anchor - please see the screenshot. 

Tested using:
Nightly 16.0a1 2012-07-01
HTC Desire (Android 2.2.2)

Comment 4

[Aaron Train [:aaronmt]]

Still an issue; still needs UX opinion

Comment 5

[Ian Barlow (:ibarlow)]

Agreed, it should open the anchor link, not the image, in a new tab.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Screenshot

What do you think of doing something like this ian? Showing the different links as different subheadings?

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 8

[Wesley Johnston (:wesj)]

Ian ping?

Comment 9

[Ian Barlow (:ibarlow)]

Wes, I think splitting the items apart like this is probably the right approach, but it also identifies some inconsistencies to me with the wording and structure we use in our various context menus. 

I'll post some suggestions here soon, but I want to take a step back and define some more general rules around our context menus first, since we don't really have anything like that at the moment.

Comment 10

[Wesley Johnston (:wesj)]

ping ian?

Comment 11

[Ian Barlow (:ibarlow)]

We're going to try a tabbed solution resembling this: http://cl.ly/image/3k3N2T3X3w2b but just a heads up that I'm going to do another pass on the visual design as well.

Comment 12

[Wesley Johnston (:wesj)]

This is going to be fixed as part of the quickshare context menu work in bug 942270

Comment 13

[Wesley Johnston (:wesj)]

Fixed in bug 942270.