710414 - Split out the conservative testing for a GCThing from marking it

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Testing an arbitrary pointer for valid GCThing-ness is useful for things other tan the GC

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Split out the conservative testing for a GCThing from marking it

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Split out the conservative testing for a GCThing from marking it

Testing an arbitrary pointer for valid GCThing-ness is useful for things other tan the GC

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 581465 [details] [diff] [review]
Split out the conservative testing for a GCThing from marking it

Removed the InFreeList() part as we discussed. It required returning the ArenaHeader pointer too; let me know if you think that's too ugly.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 581465 [details] [diff] [review]
Split out the conservative testing for a GCThing from marking it

Review of attachment 581465 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +906,5 @@
>  
>  /*
> + * Tests whether w is a live GC thing. Returns CGCT_VALID and the thingKind and
> + * address of the beginning of the GCthing if so. Otherwise returns the reason
> + * for rejection.

Could you update the comment? Maybe replace "live" with "(possibly dead)".

@@ +911,3 @@
>   */
>  inline ConservativeGCTest
> +IsAddressibleGCThing(JSRuntime *rt, jsuword w,

Addressible -> Addressable, according to Google.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/5884234f1b30