Split out the conservative testing for a GCThing from marking it

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sfink, Unassigned)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Testing an arbitrary pointer for valid GCThing-ness is useful for things other tan the GC
(Reporter)

Comment 1

6 years ago
Created attachment 581439 [details] [diff] [review]
Split out the conservative testing for a GCThing from marking it
(Reporter)

Updated

6 years ago
Attachment #581439 - Flags: review?(wmccloskey)
(Reporter)

Comment 2

6 years ago
Created attachment 581465 [details] [diff] [review]
Split out the conservative testing for a GCThing from marking it

Testing an arbitrary pointer for valid GCThing-ness is useful for things other tan the GC
(Reporter)

Updated

6 years ago
Attachment #581439 - Attachment is obsolete: true
Attachment #581439 - Flags: review?(wmccloskey)
(Reporter)

Comment 3

6 years ago
Comment on attachment 581465 [details] [diff] [review]
Split out the conservative testing for a GCThing from marking it

Removed the InFreeList() part as we discussed. It required returning the ArenaHeader pointer too; let me know if you think that's too ugly.
Attachment #581465 - Flags: review?(wmccloskey)
Comment on attachment 581465 [details] [diff] [review]
Split out the conservative testing for a GCThing from marking it

Review of attachment 581465 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsgc.cpp
@@ +906,5 @@
>  
>  /*
> + * Tests whether w is a live GC thing. Returns CGCT_VALID and the thingKind and
> + * address of the beginning of the GCthing if so. Otherwise returns the reason
> + * for rejection.

Could you update the comment? Maybe replace "live" with "(possibly dead)".

@@ +911,3 @@
>   */
>  inline ConservativeGCTest
> +IsAddressibleGCThing(JSRuntime *rt, jsuword w,

Addressible -> Addressable, according to Google.
Attachment #581465 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/5884234f1b30
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.