710473 - Backout the nsDerivedSafe part from bug 666414 to make PGO builds on Windows work again

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

https://tbpl.mozilla.org/?tree=Try&rev=a04daa5f7278 shows that backing out the nsDerivedSafe part of bug 666414 fixes the PGO builds on Windows.

Comment 1

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/221eccfa6a3f

Comment 2

[(no longer active)]

I tried backing out this patch now that the libxul problem is solved, but I got this compilation error:

e:\builds\moz2_slave\try-w32\build\obj-firefox\dist\include\nsCOMPtr.h(443) : error C3246: 'nsCOMPtr_base::nsDerivedSafe<T>' : cannot inherit from 'nsCSSStyleSheet' as it has been declared as 'sealed'

This has exceeded how much I care about this problem, so I'll declare defeat here.  :-)

Comment 3

[Mozilla RelEng Bot]

Try run for 81fffb94b73e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=81fffb94b73e
Results (out of 14 total builds):
    exception: 9
    success: 2
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-81fffb94b73e