Last Comment Bug 710473 - Backout the nsDerivedSafe part from bug 666414 to make PGO builds on Windows work again
: Backout the nsDerivedSafe part from bug 666414 to make PGO builds on Windows ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks: 666414 709193
  Show dependency treegraph
 
Reported: 2011-12-13 17:00 PST by :Ehsan Akhgari
Modified: 2012-05-01 04:26 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (4.65 KB, patch)
2011-12-13 17:00 PST, :Ehsan Akhgari
roc: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2011-12-13 17:00:55 PST
Created attachment 581483 [details] [diff] [review]
Patch (v1)

https://tbpl.mozilla.org/?tree=Try&rev=a04daa5f7278 shows that backing out the nsDerivedSafe part of bug 666414 fixes the PGO builds on Windows.
Comment 2 :Ehsan Akhgari 2012-01-03 15:05:50 PST
I tried backing out this patch now that the libxul problem is solved, but I got this compilation error:

e:\builds\moz2_slave\try-w32\build\obj-firefox\dist\include\nsCOMPtr.h(443) : error C3246: 'nsCOMPtr_base::nsDerivedSafe<T>' : cannot inherit from 'nsCSSStyleSheet' as it has been declared as 'sealed'

This has exceeded how much I care about this problem, so I'll declare defeat here.  :-)
Comment 3 Mozilla RelEng Bot 2012-01-03 15:30:57 PST
Try run for 81fffb94b73e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=81fffb94b73e
Results (out of 14 total builds):
    exception: 9
    success: 2
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-81fffb94b73e

Note You need to log in before you can comment on or make changes to this bug.