The default bug view has changed. See this FAQ.

Backout the nsDerivedSafe part from bug 666414 to make PGO builds on Windows work again

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 581483 [details] [diff] [review]
Patch (v1)

https://tbpl.mozilla.org/?tree=Try&rev=a04daa5f7278 shows that backing out the nsDerivedSafe part of bug 666414 fixes the PGO builds on Windows.
Attachment #581483 - Flags: review?(roc)
Attachment #581483 - Flags: review?(roc) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/mozilla-central/rev/221eccfa6a3f
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

5 years ago
I tried backing out this patch now that the libxul problem is solved, but I got this compilation error:

e:\builds\moz2_slave\try-w32\build\obj-firefox\dist\include\nsCOMPtr.h(443) : error C3246: 'nsCOMPtr_base::nsDerivedSafe<T>' : cannot inherit from 'nsCSSStyleSheet' as it has been declared as 'sealed'

This has exceeded how much I care about this problem, so I'll declare defeat here.  :-)

Comment 3

5 years ago
Try run for 81fffb94b73e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=81fffb94b73e
Results (out of 14 total builds):
    exception: 9
    success: 2
    failure: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-81fffb94b73e
Blocks: 750661
No longer blocks: 750661
You need to log in before you can comment on or make changes to this bug.