Last Comment Bug 710481 - Remove tracer leftovers in CustomQS_WebGL.h
: Remove tracer leftovers in CustomQS_WebGL.h
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: Trunk
: All All
-- minor (vote)
: mozilla11
Assigned To: Ed Morley [:emorley]
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: 698201
  Show dependency treegraph
 
Reported: 2011-12-13 17:30 PST by Ed Morley [:emorley]
Modified: 2011-12-16 05:48 PST (History)
6 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (14.22 KB, patch)
2011-12-13 17:33 PST, Ed Morley [:emorley]
jacob.benoit.1: review+
bhackett1024: feedback+
Details | Diff | Splinter Review

Comment 1 User image Ed Morley [:emorley] 2011-12-13 17:33:27 PST
Created attachment 581493 [details] [diff] [review]
Patch v1
Comment 2 User image Benoit Jacob [:bjacob] (mostly away) 2011-12-13 17:37:10 PST
I would like input from a JS engine guy about whether these things are really not useful anymore (e.g. are they useful with Type Inference ?)
Comment 3 User image Brian Hackett (:bhackett) 2011-12-13 17:42:42 PST
(In reply to Benoit Jacob [:bjacob] from comment #2)
> I would like input from a JS engine guy about whether these things are
> really not useful anymore (e.g. are they useful with Type Inference ?)

The traceable natives aren't used at all anymore, so this code should be removed.  At some point with IonMonkey we will be able to start calling type specialized natives again, but it's not clear yet what that will look like.
Comment 4 User image Ed Morley [:emorley] 2011-12-14 04:14:16 PST
https://tbpl.mozilla.org/?tree=Try&rev=7ce27fb4cc9d
Comment 6 User image Ed Morley [:emorley] 2011-12-16 05:48:35 PST
https://hg.mozilla.org/mozilla-central/rev/e79756f054b5

Note You need to log in before you can comment on or make changes to this bug.