71050 - buttons are blank in all dialogs

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Steve]

BuildID 2001030608

Missing the Submit(?) and Cancel words from the buttons on the Security Warning
pop-up window ("Any info you submit is insecure...") that shows up when you
submit form information.

Comment 1

[Steve]

If you go to Preferences from the Edit navbar menu, the ok and cancel buttons
are blank there as well.

Comment 2

[Bradley Hart]

I'm seeing this too, Mac OS 8.6 build 2001030608. The buttons in the "Subscribe"
dialog are also blank. Marking NEW.

Comment 3

[Bradley Hart]

Sorry about not changing the component, but I have no idea where this should go.

Comment 4

[Asa Dotzler [:asa]]

This affects all OK and Cancel buttons on Mac

Comment 5

[sairuh (rarely reading bugmail)]

seems all buttons in dialogs are affected. is there an earlier bug for this,
perchance? see this using 2001.03.06.08 [wasn't a problem in 2001.03.05.08].

Comment 6

[Simon Fraser [no longer active]]

This isn't a blocker? It could lead to serious data loss, so making blocker.

Comment 7

[sairuh (rarely reading bugmail)]

*** Bug 71147 has been marked as a duplicate of this bug. ***

Comment 8

[Mike Pinkerton (not reading bugmail)]

i don't see it in _all_ dialogs (for instance, there are buttons with text in 

prefs panels), but certainly all ok/cancel buttons are affected.

Comment 9

[Simon Fraser [no longer active]]

So it looks like buttons using the "standard" text strings (OK, Cancel) are 
blank. I checked to see if there were any string bundle loading failures, and 
there didn't appear to be for these strings.

Comment 10

[Daniel (Leaf) Nunes]

is this with all skins?

Comment 11

[Simon Fraser [no longer active]]

We think this is tao.

     brade: I think xpfe/global/resources/content/mac/platformOverlay.xul is 
wrong
     brade: <!DOCTYPE window SYSTEM "chrome://global/locale/
platformDialogOverlay.dtd">

should be:

     brade: <!DOCTYPE window SYSTEM "chrome://global-platform/locale/
platformDialogOverlay.dtd">

Tao, does this make sense?

Comment 12

[Kathleen :Brade]

searching with lxr, this is the only file that contains "global/locale/platform"

Comment 13

[Simon Fraser [no longer active]]

Patch:

Index: mozilla/xpfe/global/resources/content/mac/platformDialogOverlay.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/mac/
platformDialogOverlay.xul,v
retrieving revision 1.19
diff -u -2 -r1.19 platformDialogOverlay.xul
--- platformDialogOverlay.xul	2001/02/15 04:37:15	1.19
+++ platformDialogOverlay.xul	2001/03/07 22:10:18
@@ -22,5 +22,5 @@
 <!-- mac version of platformDialogOverlay.xul -->
 
-<!DOCTYPE window SYSTEM "chrome://global/locale/platformDialogOverlay.dtd">
+<!DOCTYPE window SYSTEM "chrome://global-platform/locale/
platformDialogOverlay.dtd">
 
 <overlay id="platformDialogOverlay"

Comment 14

[Simon Fraser [no longer active]]

sr=sfraser

Comment 15

[Kathleen :Brade]

r=brade

Comment 16

[tao]

Hi, Simon:


Would you check it it please? My Mac is down now.

thx

Comment 17

[Simon Fraser [no longer active]]

patch checked in.

Comment 18

[tao]

I lxr-ed "locale/platform" on both moz and ns trees. This is the only place needs
to be fixed. Sorry for the oversight!

Comment 19

[Asa Dotzler [:asa]]

Verified fixed with 2001030705 mozilla build on OS 9.  OK and Cancel buttons now
have visible "OK" and "Cancel" labels.

Comment 20

[Asa Dotzler [:asa]]

sorry, I meant 030715 build.

Comment 21

[sairuh (rarely reading bugmail)]

asa was using 2001.03.07.15 bits, btw.