nsIProtocolHandler needs cleanup.

VERIFIED FIXED in mozilla0.9

Status

()

Core
Networking
P2
major
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Judson Valeski, Assigned: dougt)

Tracking

({embed})

Trunk
mozilla0.9
All
Linux
embed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

17 years ago
1. nsILoadGroup and nsIInterfaceRequestor pre-defs need to be removed.
2. if not a socket using handler, the return code of defaultPort needs to be
defined as -1, and documented in comments.
3. baseURI in newURI() method needs to be documented that it can take null.
(Reporter)

Updated

17 years ago
Blocks: 70229
(Assignee)

Comment 1

17 years ago
Accepting per API review
Severity: normal → major
Status: NEW → ASSIGNED
Component: Embedding APIs → Networking
Keywords: embed
Priority: -- → P2
Hardware: PC → All
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 2

17 years ago
Checked into the tree.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

17 years ago
re-opening. doug, if you'll recall our email exchange involved leaving this
open. Please review the api notes for more info.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

17 years ago
I thought that we were talking about leaving 71054 open.  Please confirm.
(Reporter)

Comment 5

17 years ago
my bad. you're right.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 6

17 years ago
reassign qa contact to depstein.
QA Contact: mdunn → depstein

Comment 7

17 years ago
in nsIProtocolHandler.idl:
1. No nsILoadGroup or nsIInterfaceRequestor pre-defs
2. there's a comment about -1 being the default for abnormal port. (Q: In what
file is -1 default actually defined?)
3. in newURI(), there's a comment about aBaseURI possibly being nsnull.

Comment 8

17 years ago
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.