71054 - nsIChannel iface cleanup.

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

The list below reflects the review notes. If sub bugs are broken out for any of
these items, please make them blockers of this bug.

- nsIStreamProvider/nsIOutputStream/nsIStreamObserver needs to go away.
- URI attributes should be readonly. mail/news should not call
nsIChannel::SetURI(), they need to handle this internally.
- owner() attribute needs to be moved to nsIRequest and better commenting (it's
an opaque pointer that the implementor just needs to hang on to and pass
through. it cannot be abitrarily used.).
- securityInfo() should be moved into it's own iface (nsISecureChannel?) so HTTP
leverages it directly.
- loadGroup attribute should be promoted to nsIRequest.
- loadAttributes attribute (along w/ LOAD_NORMAL and LOAD_BACKGROUND. the other
enumerations stay in nsIChannel) should be promoted to nsIRequest.
- notificationCallbacks gives the caller access to nsIWebProgress and nsIPrompt.
This needs to be documented.
- nsIFileChannel and nsIStreamIOChannel should be moved into their own
respective idl files.

Comment 1

[Darin Fisher]

This is going to have to be delayed until 0.9.

Comment 2

[Darin Fisher]

fix checked in

Comment 3

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 4

[David Epstein]

bug is reopened because of #2, #4, #5, #7, and #8 below.

per the API Review Notes in above url, here's what was done:
1. nsIStreamProvider, nsIOutputStream, nsIStreamObserver were removed from 
nsIChannel.idl
2. There are 2 nsIURI attributes: originalURI (NOT read only; Jud or Daren: 
should this one also be read only?), and URI (read only). The URI returns the 
current attribute.
3. SetURI not included in this iface (so mail/news can't call 
nsIChannel::SetURI)
4. owner attribute is still in the iface. Checked nsIRequest: owner attribute 
(or method - as it says in the notes)is NOT there. It wasn't moved to nsIRequest
5. securityInfo attribute is still in the iface. Checked to see if 
nsISecureChannel exists (could NOT find it on lxr). don't know where else to 
check to see where it was moved (attribute or function).
6. loadGroup attribute is in nsIRequest. no longer in nsIChannel.
7. loadAttributes attribute is not in nsIChannel.idl, but also NOT in 
nsIRequest. LOAD_NORMAL or LOAD_BACKGROUND were moved from nsIChannel to 
nsIRequest.
8. notificationCallbacks attribute exists, but unsure how it accesses 
nsIWebProgress or nsIPrompt. Comments describe how clients use it, but don't 
describe mechanism or give example how to use it. It mentions nsIPrompt, but not 
nsIWebProgress (as mentioned in the Notes).
9. nsIFileChannel and nsIStreamIOChannel were moved to their respective idl 
files.  

Comment 5

[Jon Granrose]

SPAM: mozilla 0.9 (and M1, and 0.8.1, etc.) has left the building.  please
update the target milestone so we can get a good idea of what's left for 0.9.1.

Comment 6

[Darin Fisher]

david: those 5 points have been invalidated.

Comment 7

[David Epstein]

Thanks for the clarification. Verified.