Closed Bug 710543 Opened 10 years ago Closed 9 years ago

Bring back 'change.password.pwSameAsRecoveryKey' string

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16
Tracking Status
firefox10 --- affected
firefox11 --- affected

People

(Reporter: philikon, Assigned: raymondlee)

References

Details

(Keywords: regression, Whiteboard: [good first bug][lang=js][mentor=philikon])

Attachments

(1 file, 1 obsolete file)

Bug 675823, specifically part 4 (see bug 675823 comment 17), removed the 'change.password.pwSameAsRecoveryKey', but it's still used in the password change dialog (via syncUtils.js)

Bug 689832 comment 6 even claims that this will let you set your password to the Sync Key. I'm skeptical that this is the case, but I haven't verified.
Looping in Axel. The smallest fix here would be to simply bring back the string that was erroneously removed. Is that gonna be ok on Aurora?

If not, we can also just get rid of the check entirely. I mean, we don't let users choose their own Sync Key anymore anyway. The whole "your password mustn't be equal to your passphrase" isn't really an issue anymore. If you want your password to be a 26 character long ass string, fine...
We're 5 weeks into the string freeze on aurora, we should get along without this string, if possible.
Then I propose we just rip out that functionality. rnewman, what do you think?
(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> Then I propose we just rip out that functionality. rnewman, what do you
> think?

I was just about to say!

I think the original intent was to remove that check anyway. It pretty much stopped making sense once users could no longer pick a passphrase.
Whiteboard: [good first bug][lang=js][mentor=philikon]
Attached patch v1 (obsolete) — Splinter Review
Removed the check which uses "change.password.pwSameAsRecoveryKey".
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #623047 - Flags: review?(philipp)
Comment on attachment 623047 [details] [diff] [review]
v1

403 gps
Attachment #623047 - Flags: review?(philipp) → review?(gps)
Comment on attachment 623047 [details] [diff] [review]
v1

Review of attachment 623047 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Raymond: Will you need someone to commit this for you? If so, please confirm the name and email address you would like reflected in the source control system and I will commit it for you.
Attachment #623047 - Flags: review?(gps) → review+
Please you commit that for me. Thanks!
Attachment #623047 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e48be93aa253
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.