Bring back 'change.password.pwSameAsRecoveryKey' string

RESOLVED FIXED in mozilla16

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: philikon, Assigned: raymondlee)

Tracking

({regression})

unspecified
mozilla16
regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox10 affected, firefox11 affected)

Details

(Whiteboard: [good first bug][lang=js][mentor=philikon])

Attachments

(1 attachment, 1 obsolete attachment)

Bug 675823, specifically part 4 (see bug 675823 comment 17), removed the 'change.password.pwSameAsRecoveryKey', but it's still used in the password change dialog (via syncUtils.js)

Bug 689832 comment 6 even claims that this will let you set your password to the Sync Key. I'm skeptical that this is the case, but I haven't verified.
Looping in Axel. The smallest fix here would be to simply bring back the string that was erroneously removed. Is that gonna be ok on Aurora?

If not, we can also just get rid of the check entirely. I mean, we don't let users choose their own Sync Key anymore anyway. The whole "your password mustn't be equal to your passphrase" isn't really an issue anymore. If you want your password to be a 26 character long ass string, fine...
status-firefox10: --- → affected
status-firefox11: --- → affected
Keywords: regression

Comment 2

6 years ago
We're 5 weeks into the string freeze on aurora, we should get along without this string, if possible.
Then I propose we just rip out that functionality. rnewman, what do you think?
(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> Then I propose we just rip out that functionality. rnewman, what do you
> think?

I was just about to say!

I think the original intent was to remove that check anyway. It pretty much stopped making sense once users could no longer pick a passphrase.
(Reporter)

Updated

6 years ago
Whiteboard: [good first bug][lang=js][mentor=philikon]
(Assignee)

Comment 5

6 years ago
Created attachment 623047 [details] [diff] [review]
v1

Removed the check which uses "change.password.pwSameAsRecoveryKey".
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #623047 - Flags: review?(philipp)
Comment on attachment 623047 [details] [diff] [review]
v1

403 gps
Attachment #623047 - Flags: review?(philipp) → review?(gps)

Comment 7

6 years ago
Comment on attachment 623047 [details] [diff] [review]
v1

Review of attachment 623047 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Raymond: Will you need someone to commit this for you? If so, please confirm the name and email address you would like reflected in the source control system and I will commit it for you.
Attachment #623047 - Flags: review?(gps) → review+
(Assignee)

Comment 8

6 years ago
Created attachment 623904 [details] [diff] [review]
Patch for checkin

Please you commit that for me. Thanks!
Attachment #623047 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e48be93aa253
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.