710543 - Bring back 'change.password.pwSameAsRecoveryKey' string

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Bug 675823, specifically part 4 (see bug 675823 comment 17), removed the 'change.password.pwSameAsRecoveryKey', but it's still used in the password change dialog (via syncUtils.js)

Bug 689832 comment 6 even claims that this will let you set your password to the Sync Key. I'm skeptical that this is the case, but I haven't verified.

Comment 1

[Philipp von Weitershausen [:philikon]]

Looping in Axel. The smallest fix here would be to simply bring back the string that was erroneously removed. Is that gonna be ok on Aurora?

If not, we can also just get rid of the check entirely. I mean, we don't let users choose their own Sync Key anymore anyway. The whole "your password mustn't be equal to your passphrase" isn't really an issue anymore. If you want your password to be a 26 character long ass string, fine...

Comment 2

[Axel Hecht [:Pike]]

We're 5 weeks into the string freeze on aurora, we should get along without this string, if possible.

Comment 3

[Philipp von Weitershausen [:philikon]]

Then I propose we just rip out that functionality. rnewman, what do you think?

Comment 4

[Richard Newman [:rnewman]]

(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> Then I propose we just rip out that functionality. rnewman, what do you
> think?

I was just about to say!

I think the original intent was to remove that check anyway. It pretty much stopped making sense once users could no longer pick a passphrase.

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: v1

Removed the check which uses "change.password.pwSameAsRecoveryKey".

Comment 6

[Philipp von Weitershausen [:philikon]]

Comment on attachment 623047 [details] [diff] [review]
v1

403 gps

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 623047 [details] [diff] [review]
v1

Review of attachment 623047 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Raymond: Will you need someone to commit this for you? If so, please confirm the name and email address you would like reflected in the source control system and I will commit it for you.

Comment 8

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Please you commit that for me. Thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e48be93aa253

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e48be93aa253