710548 - Add the offline-app, webapp-manage permissions to pre-installed apps.

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Add offline-app, webapp-manage permissions to pre-installed app

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 581540 [details] [diff] [review]
Add offline-app, webapp-manage permissions to pre-installed app

>diff --git a/b2g/chrome/content/shell.js b/b2g/chrome/content/shell.js

>+// XXX until we have a security model, add some rights to
>+// the pre-installed web applications 
>+function addPermissions(urls) {
>+  let permissions = ['indexedDB', 'webapps-manage', 'offline-app'];

Giving all app "webapps-manage" really sucks, but I understand why
you're doing it.  Instead of an XXX here, let's find a bug to link
here with a FIXME comment, or push on Jonas/WebAPI team to file one.

>@@ -251,10 +258,18 @@ var shell = {
>             return;
> 
>           let documentURI = contentWindow.document.documentURIObject;
>-          let manifestURI = Services.io.newURI(manifest, null, documentURI);
>+          if (!Services.perms.testPermission(documentURI, 'offline-app')) {
>+            if (Services.prefs.getBoolPref('browser.offline-apps.notify')) {
>+              // TODO Add code to handle the notification UI

"FIXME/bug XXXXXX: [blah]"

r=me with those fixes.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch for check-in

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch for check-in

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mozilla-central/rev/fe5bd75f1553