Closed
Bug 710581
Opened 14 years ago
Closed 14 years ago
set-but-unused warning in PropertyCache::fullTest withh GCC 4.6
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: igor, Assigned: igor)
Details
Attachments
(1 file)
|
831 bytes,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
For optimized builds GCC 4.6 reports :
.../js/src/jspropertycache.cpp: In member function ‘JSAtom* js::PropertyCache::fullTest(JSContext*, jsbytecode*, JSObject**, JSObject**, js::PropertyCacheEntry*)’:
/home/igor/m/mc/js/src/jspropertycache.cpp:188:15: warning: unused variable ‘script’ [-Wunused-variable]
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: general → igor
Attachment #581581 -
Flags: review?(bhackett1024)
|
|
Assignee | |
Comment 2•14 years ago
|
||
The patch uses explicit #ifdef DEBUG and not DebugOnly<JScript *> script = cx->stack.currentScript(). The right-hand side here is rather complex inline function and contains calls to functions defined in other files. So a compiler most likely will not see that the function does not affect the global state and preserve the call.
|
||
Updated•14 years ago
|
Attachment #581581 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•