710581 - set-but-unused warning in PropertyCache::fullTest withh GCC 4.6

Status: RESOLVED FIXED

Description

[Igor Bukanov]

For optimized builds GCC 4.6 reports :

.../js/src/jspropertycache.cpp: In member function ‘JSAtom* js::PropertyCache::fullTest(JSContext*, jsbytecode*, JSObject**, JSObject**, js::PropertyCacheEntry*)’:
/home/igor/m/mc/js/src/jspropertycache.cpp:188:15: warning: unused variable ‘script’ [-Wunused-variable]

Comment 1

[Igor Bukanov]

Created attachment 581581 [details] [diff] [review]
fix

Comment 2

[Igor Bukanov]

The patch uses explicit #ifdef DEBUG and not DebugOnly<JScript *> script = cx->stack.currentScript(). The right-hand side here is rather complex inline function and contains calls to functions defined in other files. So a compiler most likely will not see that the function does not affect the global state and preserve the call.

Comment 3

[Igor Bukanov]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a129c639c0f1

Comment 4

[:Ms2ger (⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/a129c639c0f1