Closed Bug 710581 Opened 10 years ago Closed 10 years ago

set-but-unused warning in PropertyCache::fullTest withh GCC 4.6

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: igor, Assigned: igor)

Details

Attachments

(1 file)

fix
831 bytes, patch
bhackett1024
: review+
Details | Diff | Splinter Review 
For optimized builds GCC 4.6 reports :

.../js/src/jspropertycache.cpp: In member function ‘JSAtom* js::PropertyCache::fullTest(JSContext*, jsbytecode*, JSObject**, JSObject**, js::PropertyCacheEntry*)’:
/home/igor/m/mc/js/src/jspropertycache.cpp:188:15: warning: unused variable ‘script’ [-Wunused-variable]
Attached patch fix — — Splinter Review
Assignee: general → igor
Attachment #581581 - Flags: review?(bhackett1024)
The patch uses explicit #ifdef DEBUG and not DebugOnly<JScript *> script = cx->stack.currentScript(). The right-hand side here is rather complex inline function and contains calls to functions defined in other files. So a compiler most likely will not see that the function does not affect the global state and preserve the call.
Attachment #581581 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/a129c639c0f1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.